diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 13:47:16 +0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-27 00:28:27 +0300 |
| commit | 9e8014fcaf80cd9e49db2e551c16a1b6aaaf048f (patch) | |
| tree | 36adb95751893841aabe029d90bcd71fd9416a22 /drivers/gpio/gpio-twl4030.c | |
| parent | 27ca226711d4bb438349fe0575660a60ad56b357 (diff) | |
| download | linux-9e8014fcaf80cd9e49db2e551c16a1b6aaaf048f.tar.xz | |
gpio: twl4030: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
This also makes the driver start to return the error code, as the
end of the series make this work.
Cc: Roger Quadros <rogerq@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-twl4030.c')
| -rw-r--r-- | drivers/gpio/gpio-twl4030.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c index 14f40bf64e34..f5590514838a 100644 --- a/drivers/gpio/gpio-twl4030.c +++ b/drivers/gpio/gpio-twl4030.c @@ -327,7 +327,7 @@ static int twl_get(struct gpio_chip *chip, unsigned offset) else status = twl4030_get_gpio_datain(offset); - ret = (status <= 0) ? 0 : 1; + ret = (status < 0) ? status : !!status; out: mutex_unlock(&priv->mutex); return ret; |