diff options
| author | Kees Cook <keescook@chromium.org> | 2018-11-02 02:17:22 +0300 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2018-11-30 00:46:43 +0300 |
| commit | 89d328f637b9904b6d4c9af73c8a608b8dd4d6f8 (patch) | |
| tree | 57b3e1dbdff2aff069cb59aa9414fbeb6bd430ea /certs | |
| parent | 1227daa43bce1318ff6fb54e6cd862b4f60245c7 (diff) | |
| download | linux-89d328f637b9904b6d4c9af73c8a608b8dd4d6f8.tar.xz | |
pstore/ram: Correctly calculate usable PRZ bytes
The actual number of bytes stored in a PRZ is smaller than the
bytes requested by platform data, since there is a header on each
PRZ. Additionally, if ECC is enabled, there are trailing bytes used
as well. Normally this mismatch doesn't matter since PRZs are circular
buffers and the leading "overflow" bytes are just thrown away. However, in
the case of a compressed record, this rather badly corrupts the results.
This corruption was visible with "ramoops.mem_size=204800 ramoops.ecc=1".
Any stored crashes would not be uncompressable (producing a pstorefs
"dmesg-*.enc.z" file), and triggering errors at boot:
[ 2.790759] pstore: crypto_comp_decompress failed, ret = -22!
Backporting this depends on commit 70ad35db3321 ("pstore: Convert console
write to use ->write_buf")
Reported-by: Joel Fernandes <joel@joelfernandes.org>
Fixes: b0aad7a99c1d ("pstore: Add compression support to pstore")
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Diffstat (limited to 'certs')
0 files changed, 0 insertions, 0 deletions