summaryrefslogtreecommitdiff
path: root/arch/arm/include
diff options
context:
space:
mode:
authorRussell King <rmk@dyn-67.arm.linux.org.uk>2008-09-29 16:48:17 +0400
committerRussell King <rmk+kernel@arm.linux.org.uk>2008-09-29 16:54:28 +0400
commit0e18b5d7c6339311f1e32e7b186ae3556c5b6d33 (patch)
treed9c3ce8112509cbf0e1e8e668711c1375feb4120 /arch/arm/include
parent3216a97bb0d5166ec5795aa3db1c3a02415ac060 (diff)
downloadlinux-0e18b5d7c6339311f1e32e7b186ae3556c5b6d33.tar.xz
[ARM] dma: add validation of DMA params
Validate the direction argument like x86 does. In addition, validate the dma_unmap_* parameters against those passed to dma_map_* when using the DMA bounce code. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/include')
-rw-r--r--arch/arm/include/asm/dma-mapping.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h
index 1532b7a6079d..2544a087c213 100644
--- a/arch/arm/include/asm/dma-mapping.h
+++ b/arch/arm/include/asm/dma-mapping.h
@@ -277,6 +277,8 @@ int dmabounce_sync_for_device(struct device *, dma_addr_t, unsigned long,
static inline dma_addr_t dma_map_single(struct device *dev, void *cpu_addr,
size_t size, enum dma_data_direction dir)
{
+ BUG_ON(!valid_dma_direction(dir));
+
if (!arch_is_coherent())
dma_cache_maint(cpu_addr, size, dir);
@@ -301,6 +303,8 @@ static inline dma_addr_t dma_map_single(struct device *dev, void *cpu_addr,
static inline dma_addr_t dma_map_page(struct device *dev, struct page *page,
unsigned long offset, size_t size, enum dma_data_direction dir)
{
+ BUG_ON(!valid_dma_direction(dir));
+
if (!arch_is_coherent())
dma_cache_maint(page_address(page) + offset, size, dir);
@@ -370,6 +374,8 @@ static inline void dma_sync_single_range_for_cpu(struct device *dev,
dma_addr_t handle, unsigned long offset, size_t size,
enum dma_data_direction dir)
{
+ BUG_ON(!valid_dma_direction(dir));
+
if (!dmabounce_sync_for_cpu(dev, handle, offset, size, dir))
return;
@@ -381,6 +387,8 @@ static inline void dma_sync_single_range_for_device(struct device *dev,
dma_addr_t handle, unsigned long offset, size_t size,
enum dma_data_direction dir)
{
+ BUG_ON(!valid_dma_direction(dir));
+
if (!dmabounce_sync_for_device(dev, handle, offset, size, dir))
return;