diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2016-01-21 01:58:58 +0300 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-01-21 04:09:18 +0300 |
| commit | 7047d813718c8e40929b7267a8d20cbf212f8565 (patch) | |
| tree | 7da361cc2cc4638e856109d646154470b7236d4b | |
| parent | ad27a7559a85309a4775389d012f3728c92f5eb0 (diff) | |
| download | linux-7047d813718c8e40929b7267a8d20cbf212f8565.tar.xz | |
test_hexdump: switch to memcmp()
Better to use memcmp() against entire buffer to check that nothing is
happened to the data in the tail.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | lib/test_hexdump.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c index 141d031e6a13..4b949aac6f08 100644 --- a/lib/test_hexdump.c +++ b/lib/test_hexdump.c @@ -72,8 +72,6 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize, else result = test_data_1_le; - memset(test, FILL_CHAR, testlen); - /* hex dump */ p = test; for (i = 0; i < l / gs; i++) { @@ -109,13 +107,15 @@ static void __init test_hexdump(size_t len, int rowsize, int groupsize, char test[TEST_HEXDUMP_BUF_SIZE]; char real[TEST_HEXDUMP_BUF_SIZE]; + memset(real, FILL_CHAR, sizeof(real)); hex_dump_to_buffer(data_b, len, rowsize, groupsize, real, sizeof(real), ascii); + memset(test, FILL_CHAR, sizeof(test)); test_hexdump_prepare_test(len, rowsize, groupsize, test, sizeof(test), ascii); - if (strcmp(test, real)) { + if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) { pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize); pr_err("Result: '%s'\n", real); pr_err("Expect: '%s'\n", test); |