diff options
| author | Tom Rini <trini@konsulko.com> | 2015-12-08 00:26:08 +0300 |
|---|---|---|
| committer | Michal Marek <mmarek@suse.com> | 2016-02-18 00:52:04 +0300 |
| commit | 46fe94ad18aa7ce6b3dad8c035fb538942020f2b (patch) | |
| tree | ef7acb440291f285efdb6dc910aec8c1abf1db70 | |
| parent | a043934207c5eb271deeaed2e9bd019c3be92cad (diff) | |
| download | linux-46fe94ad18aa7ce6b3dad8c035fb538942020f2b.tar.xz | |
kbuild: fixdep: Check fstat(2) return value
Coverity has recently added a check that will find when we don't check
the return code from fstat(2). Copy/paste the checking logic that
print_deps() has with an appropriate re-wording of the perror() message.
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Michal Marek <mmarek@suse.com>
| -rw-r--r-- | scripts/basic/fixdep.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index 5b327c67a828..caef815d1743 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@ -274,7 +274,11 @@ static void do_config_file(const char *filename) perror(filename); exit(2); } - fstat(fd, &st); + if (fstat(fd, &st) < 0) { + fprintf(stderr, "fixdep: error fstat'ing config file: "); + perror(filename); + exit(2); + } if (st.st_size == 0) { close(fd); return; |