diff options
author | Joe Perches <joe@perches.com> | 2013-11-07 23:55:15 +0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2013-11-08 00:22:23 +0400 |
commit | 3b70a67da0bebca02a130eff8084eee457a2b836 (patch) | |
tree | 17df7a5144185ec0264cbce219b44ea47870e986 | |
parent | ca2b029515b4a81bbedcffc69a5d9574bb5ba475 (diff) | |
download | linux-3b70a67da0bebca02a130eff8084eee457a2b836.tar.xz |
ALSA: hda_intel: ratelimit "spurious response" message
dmesg here has a 100+ consecutive lines of:
[ 1464.219446] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219451] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
[ 1464.219454] hda-intel 0000:00:14.2: spurious response 0x0:0x0, last cmd=0x170500
...
Ratelimit the message to reduce the dmesg log noise.
Coalesce the format while at it.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r-- | sound/pci/hda/hda_intel.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 17f4aa8cddd5..7a09404579a7 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -914,12 +914,12 @@ static void azx_update_rirb(struct azx *chip) chip->rirb.res[addr] = res; smp_wmb(); chip->rirb.cmds[addr]--; - } else - snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, " - "last cmd=%#08x\n", + } else if (printk_ratelimit()) { + snd_printk(KERN_ERR SFX "%s: spurious response %#x:%#x, last cmd=%#08x\n", pci_name(chip->pci), res, res_ex, chip->last_cmd[addr]); + } } } |