BMC/Intel-BMC/linux.git/sound/synth, branch dev

ALSA: emux: Fix/cleanup old ifdef CONFIG_PROC_FS

2015-05-29T05:58:11+00:00

Build emux_proc.o and drop the unneeded ifdefs. Replace the left CONFIG_PROC with the new CONFIG_SND_PROC_FS. Along with this, fix the build of emux_oss.o in Makefile, too. Signed-off-by: Takashi Iwai

ALSA: emux: Fix mutex deadlock in OSS emulation

2015-04-28T15:45:45+00:00

The OSS emulation in synth-emux helper has a potential AB/BA deadlock at the simultaneous closing and opening: close -> snd_seq_release() -> sne_seq_free_client() -> snd_seq_delete_all_ports(): takes client->ports_mutex -> port_delete() -> snd_emux_unuse(): takes emux->register_mutex open -> snd_seq_oss_open() -> snd_emux_open_seq_oss(): takes emux->register_mutex -> snd_seq_event_port_attach() -> snd_seq_create_port(): takes client->ports_mutex This patch addresses the deadlock by reducing the rance taking emux->register_mutex in snd_emux_open_seq_oss(). The lock is needed for the refcount handling, so move it locally. The calls in emux_seq.c are already with the mutex, thus they are replaced with the version without mutex lock/unlock. Cc: Signed-off-by: Takashi Iwai

ALSA: emux: Fix mutex deadlock at unloading

2015-04-27T12:50:39+00:00

The emux-synth driver has a possible AB/BA mutex deadlock at unloading the emu10k1 driver: snd_emux_free() -> snd_emux_detach_seq(): mutex_lock(&emu->register_mutex) -> snd_seq_delete_kernel_client() -> snd_seq_free_client(): mutex_lock(®ister_mutex) snd_seq_release() -> snd_seq_free_client(): mutex_lock(®ister_mutex) -> snd_seq_delete_all_ports() -> snd_emux_unuse(): mutex_lock(&emu->register_mutex) Basically snd_emux_detach_seq() doesn't need a protection of emu->register_mutex as it's already being unregistered. So, we can get rid of this for avoiding the deadlock. Cc: Signed-off-by: Takashi Iwai

ALSA: Include linux/uaccess.h and linux/bitopts.h instead of asm/*

2015-01-28T16:25:07+00:00

Signed-off-by: Takashi Iwai

ALSA: emux: Use setup_timer() and mod_timer()

2015-01-19T10:41:13+00:00

No functional change, refactoring with the standard helpers. Signed-off-by: Takashi Iwai

ALSA: emux: Delete an unnecessary check before the function call "snd_sf_free"

2015-01-04T14:12:29+00:00

The snd_sf_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai

ALSA: synth: emux: soundfont.c: Cleaning up memory leak

2014-06-01T12:33:09+00:00

There is a risk for memory leak in when something unexpected happens and the function returns. This was largely found by using a static code analysis program called cppcheck. [fixed a typo of kfree() by tiwai] Signed-off-by: Rickard Strandqvist Signed-off-by: Takashi Iwai

sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed

2011-10-31T23:31:22+00:00

These aren't modules, but they do make use of these macros, so they will need export.h to get that definition. Previously, they got it via the implicit module.h inclusion. Signed-off-by: Paul Gortmaker

sound: Add module.h to the previously silent sound users

2011-10-31T23:31:21+00:00

Lots of sound drivers were getting module.h via the implicit presence of it in but we are going to clean that up. So fix up those users now. Signed-off-by: Paul Gortmaker

ALSA: emux: Add trivial compat ioctl handler

2010-09-14T14:18:11+00:00

Reported-by: Carmen Cru Signed-off-by: Ben Hutchings Signed-off-by: Takashi Iwai