BMC/Intel-BMC/linux.git/sound/pci/riptide, branch dev

ALSA: off by one bug in snd_riptide_joystick_probe()

2015-02-09T13:57:15+00:00

The problem here is that we check: if (dev >= SNDRV_CARDS) Then we increment "dev". if (!joystick_port[dev++]) Then we use it as an offset into a array with SNDRV_CARDS elements. if (!request_region(joystick_port[dev], 8, "Riptide gameport")) { This has 3 effects: 1) If you use the module option to specify the joystick port then it has to be shifted one space over. 2) The wrong error message will be printed on failure if you have over 32 cards. 3) Static checkers will correctly complain that are off by one. Fixes: db1005ec6ff8 ('ALSA: riptide - Fix joystick resource handling') Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai

ALSA: Include linux/io.h instead of asm/io.h

2015-01-28T15:49:33+00:00

Nowadays it's recommended. Replace all in a shot. Signed-off-by: Takashi Iwai

Merge branch 'topic/pci-cleanup' into for-next

2015-01-11T10:26:48+00:00

ALSA: riptide: Simplify PM callbacks

2015-01-09T16:28:43+00:00

This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801: PCI core handles power state for us]. Since pci_set_power_state(), pci_save_state() and pci_restore_state() are already done in the PCI core side, so we don't need to it doubly. Also, pci_enable_device(), pci_disable_device() and pci_set_master() calls in PM callbacks are superfluous nowadays, too, so get rid of them as well. Signed-off-by: Takashi Iwai

ALSA: riptide: Remove always NULL parameter

2015-01-02T15:33:36+00:00

snd_riptide_pcm() takes a pointer to a pointer of a PCM where if this parameter is provided the newly allocated PCM is stored. All callers pass NULL though, so remove the parameter. This makes the code a bit cleaner and shorter. Signed-off-by: Lars-Peter Clausen Signed-off-by: Takashi Iwai

PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

2014-08-12T18:15:14+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const struct pci_device_id i[] = z; // [bhelgaas: add semantic patch] Signed-off-by: Benoit Taine Signed-off-by: Bjorn Helgaas

ALSA: riptide: fix %d confusingly prefixed with 0x in format strings

2014-08-04T11:17:53+00:00

Signed-off-by: Hans Wennborg Signed-off-by: Takashi Iwai

ALSA: pci: Convert to snd_card_new() with a device pointer

2014-02-12T10:17:52+00:00

Also remove superfluous snd_card_set_dev() calls. Signed-off-by: Takashi Iwai

ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove

2013-05-29T10:37:32+00:00

As drvdata is cleared to NULL at probe failure or at removal by the driver core, we don't have to call pci_set_drvdata(pci, NULL) any longer in each driver. The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in hda_intel.c. Since this function itself releases the card instance, we need to clear drvdata here as well, so that it won't be released doubly in the remove callback. Signed-off-by: Takashi Iwai

ALSA: pci: remove __dev* attributes

2012-12-07T06:20:55+00:00

CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton Signed-off-by: Takashi Iwai