BMC/Intel-BMC/linux.git/sound/firewire, branch v3.16

ALSA: bebob: Correction for return value of special_clk_ctl_put() in error

2014-07-22T15:31:28+00:00

This commit is a supplement to my previous patch. http://mailman.alsa-project.org/pipermail/alsa-devel/2014-July/079190.html The special_clk_ctl_put() still returns 0 in error handling case. It should return -EINVAL. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: bebob: Correction for return value of .put callback

2014-07-22T14:21:54+00:00

This commit is for correction of my misunderstanding about return value of .put callback in ALSA Control interface. According to 'Writing ALSA Driver' (*1), return value of the callback has three patterns; 1: changed, 0: not changed, an negative value: fatal error. But I misunderstood that it's boolean; zero or nonzero. *1: Writing an ALSA Driver (2005, Takashi Iwai) http://www.alsa-project.org/main/index.php/ALSA_Driver_Documentation Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: bebob: Use different labels for digital input/output

2014-07-22T14:21:30+00:00

This commit uses different labels for control elements of digital input/output interfaces to correct my misunderstanding about M-Audio Firewire 1814 and ProjectMix I/O. According to user manuals for these two models, they have two modes for digital input; one is S/PDIF in both of optical and coaxial interfaces, another is ADAT in optical interface only. But in current implementation, a control element for it reduced labels which a control element for digital output uses because of my misunderstanding that optical interface is not available for digital input with S/PDIF mode. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: bebob: Fix a missing to unlock mutex in error handling case

2014-07-22T14:21:17+00:00

In error handling case, special_clk_ctl_put() returns without unlock_mutex(), therefore the mutex is still locked. This commit moves mutex_lock() after the error handling case. This commit is my solution for this post. [PATCH -next] ALSA: bebob: Fix missing unlock on error in special_clk_ctl_put() https://lkml.org/lkml/2014/7/20/12 Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: bebob: Remove unused function prototype

2014-06-04T12:38:16+00:00

snd_bebob_stream_map() is not defined. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireworks: Remove meaningless mutex_destroy()

2014-06-04T12:37:59+00:00

Currently mutex_destroy() is called in module's cleanup function. But after cleaned up, this mutex is automatically released. So this function call is meaningless. [fixed a typo in changelog by tiwai] Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireworks: Remove a constant over width to which it's applied

2014-06-04T12:36:40+00:00

The constants of enum snd_efw_grp_type is for struct snd_efw_phys_grp.type. But this member is 1 byte. Although the value is between 0x00-0xff, a constant has 0x10000. This constant is meaningless. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireworks: Improve comments about Fireworks transaction

2014-06-04T12:36:21+00:00

It includes descriptions to cause misreading. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireworks: Use safer way to arrange ring buffer pointer

2014-06-04T12:35:40+00:00

To reverse a pointer for the ring buffer, subtraction by buffer size is better than assignment to the beginning of the buffer. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: fireworks/bebob: Shorten critical section for stream_stop_duplex()

2014-06-04T12:35:24+00:00

All assignment for local variables in these functions are not related to critical section. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai