BMC/Intel-BMC/linux.git/sound/core/control.c, branch dev

ALSA: ctl: fix to handle several elements added by one operation for userspace element

2015-04-13T08:31:49+00:00

An element instance can have several elements with the same feature. Some userspace applications can add such an element instance by add operation with the number of elements. Then, the element instance gets a memory object to keep states of these elements. But the element instance has just one memory object for the elements. This causes the same result to each read/write operations to the different elements. This commit fixes this bug by allocating enough memory objects to the element instance for each of elements. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: control: Fix a typo of SNDRV_CTL_ELEM_ACCESS_TLV_* with SNDRV_CTL_TLV_OP_*

2015-04-12T07:18:14+00:00

The commit [39d118677baa: ALSA: ctl: evaluate macro instead of numerical value] replaced the numbers with constants, but one place was replaced wrongly with a different type. Fixed now. Fixes: 39d118677baa ('ALSA: ctl: evaluate macro instead of numerical value') Signed-off-by: Takashi Iwai

ALSA: ctl: fill identical information to return value when adding userspace elements

2015-04-11T15:35:17+00:00

currently some members related identical information are not fiiled in returned parameter of SNDRV_CTL_IOCTL_ELEM_ADD. This is not better for userspace application. This commit copies information to returned value. When failing to copy into userspace, the added elements are going to be removed. Then, no applications can lock these elements between adding and removing because these are already locked. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: ctl: fix a bug to return no identical information in info operation for userspace controls

2015-04-11T15:32:16+00:00

In operations of SNDRV_CTL_IOCTL_ELEM_INFO, identical information in returned value is cleared. This is not better to userspace application. This commit confirms to return full identical information to the operations. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: ctl: confirm to return all identical information in 'activate' event

2015-04-11T15:31:31+00:00

When event originator doesn't set numerical ID in identical information, the event data includes no numerical ID, thus userspace applications cannot identify the control just by unique ID in event data. This commit fix this bug so as the event data includes all of identical information. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: ctl: evaluate macro instead of numerical value

2015-04-10T07:36:25+00:00

SNDRV_CTL_TLV_OP_XXX is defined but not used in core code. Instead, raw numerical value is evaluated. This commit replaces these values to these macros for better looking. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

ALSA: control: Fix breakage of user ctl element addition

2015-03-13T06:21:51+00:00

In the commit [2225e79b9b03: 'ALSA: core: reduce stack usage related to snd_ctl_new()'], the id field of the newly added kctl is untouched, thus all attribute like name string remain empty. The fix is just to add the forgotten memcpy of the id field. Fixes: 2225e79b9b03 ('ALSA: core: reduce stack usage related to snd_ctl_new()') Reviewed-by: Takashi Sakamoto Signed-off-by: Takashi Iwai

Merge branch 'for-linus' into for-next

2015-03-12T06:38:46+00:00

ALSA: control: Add sanity checks for user ctl id name string

2015-03-12T06:36:38+00:00

There was no check about the id string of user control elements, so we accepted even a control element with an empty string, which is obviously bogus. This patch adds more sanity checks of id strings. Cc: Signed-off-by: Takashi Iwai

ALSA: core: Drop superfluous error/debug messages after malloc failures

2015-03-10T14:42:14+00:00

The kernel memory allocators already report the errors when the requested allocation fails, thus we don't need to warn it again in each caller side. Signed-off-by: Takashi Iwai