BMC/Intel-BMC/linux.git/net/sched/cls_flow.c, branch dev

sched: cls_flow: fix panic on filter replace

2015-07-21T07:25:03+00:00

The following test case causes a NULL pointer dereference in cls_flow: tc filter add dev foo parent 1: handle 0x1 flow hash keys dst action ok tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ flow hash keys mark action drop To be more precise, actually two different panics are fixed, the first occurs because tcf_exts_init() is not called on the newly allocated filter when we do a replace. And the second panic uncovered after that happens since the arguments of list_replace_rcu() are swapped, the old element needs to be the first argument and the new element the second. Fixes: 70da9f0bf999 ("net: sched: cls_flow use RCU") Signed-off-by: Daniel Borkmann Acked-by: John Fastabend Signed-off-by: David S. Miller

net: Add full IPv6 addresses to flow_keys

2015-06-04T22:44:30+00:00

This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src functions which are used to get a u32 representation of the source and destination addresses. For IPv6, ipv6_addr_hash is called. These functions retain getting the legacy values of src and dst in flow_keys. With this patch, Ethertype and IP protocol are now included in the flow hash input. Signed-off-by: Tom Herbert Signed-off-by: David S. Miller

flow_dissector: change port array into src, dst tuple

2015-05-13T19:19:47+00:00

Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller

flow_dissect: use programable dissector in skb_flow_dissect and friends

2015-05-13T19:19:47+00:00

Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller

net: change name of flow_dissector header to match the .c file name

2015-05-13T19:19:45+00:00

add couple of empty lines on the way. Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller

net_sched: destroy proto tp when all filters are gone

2015-03-09T19:35:55+00:00

Kernel automatically creates a tp for each (kind, protocol, priority) tuple, which has handle 0, when we add a new filter, but it still is left there after we remove our own, unless we don't specify the handle (literally means all the filters under the tuple). For example this one is left: # tc filter show dev eth0 filter parent 8001: protocol arp pref 49152 basic The user-space is hard to clean up these for kernel because filters like u32 are organized in a complex way. So kernel is responsible to remove it after all filters are gone. Each type of filter has its own way to store the filters, so each type has to provide its way to check if all filters are gone. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim Signed-off-by: David S. Miller

net: sched: fix skb->protocol use in case of accelerated vlan path

2015-01-13T22:51:08+00:00

tc code implicitly considers skb->protocol even in case of accelerated vlan paths and expects vlan protocol type here. However, on rx path, if the vlan header was already stripped, skb->protocol contains value of next header. Similar situation is on tx path. So for skbs that use skb->vlan_tci for tagging, use skb->vlan_proto instead. Reported-by: Jamal Hadi Salim Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim Signed-off-by: David S. Miller

net: sched: cls: use nla_nest_cancel instead of nlmsg_trim

2014-12-10T02:49:58+00:00

To cancel nesting, this function is more convenient. Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller

net: sched: cls: remove unused op put from tcf_proto_ops

2014-12-09T19:49:02+00:00

It is never called and implementations are void. So just remove it. Signed-off-by: Jiri Pirko Signed-off-by: Jamal Hadi Salim Signed-off-by: David S. Miller

net_sched: cls_flow: remove duplicate assignments

2014-12-09T01:53:41+00:00

Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller