BMC/Intel-BMC/linux.git/net/bluetooth/cmtp/core.c, branch dev-4.6

Bluetooth: Delete an unnecessary check before the function call "kfree_skb"

2015-11-19T16:50:32+00:00

The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Marcel Holtmann

Bluetooth: cmtp: Use BIT(x) instead of (1 << x)

2015-04-04T05:50:20+00:00

Signed-off-by: Marcel Holtmann Signed-off-by: Johan Hedberg

Bluetooth: Restrict CMTP flags to only valid ones

2015-04-02T05:42:21+00:00

The CMTP flags should be clearly restricted to valid ones. So this puts extra checks in place to ensure this. Signed-off-by: Marcel Holtmann Signed-off-by: Johan Hedberg

Bluetooth: cmtp: cmtp_add_connection() should verify that it's dealing with l2cap socket

2014-12-19T12:48:21+00:00

... rather than relying on ciptool(8) never passing it anything else. Give it e.g. an AF_UNIX connected socket (from socketpair(2)) and it'll oops, trying to evaluate &l2cap_pi(sock->sk)->chan->dst... Signed-off-by: Al Viro Signed-off-by: Marcel Holtmann

Bluetooth: Access CMTP session addresses through L2CAP channel

2013-10-13T17:00:30+00:00

The L2CAP socket structure does not contain the address information anymore. They need to be accessed through the L2CAP channel. Signed-off-by: Marcel Holtmann Signed-off-by: Johan Hedberg

Bluetooth: Use %pMR in sprintf/seq_printf instead of batostr

2012-09-27T21:10:15+00:00

Instead of old unsafe batostr function use %pMR print specifier for printing Bluetooth addresses in sprintf and seq_printf statements. Signed-off-by: Andrei Emeltchenko Acked-by: Marcel Holtmann Signed-off-by: Gustavo Padovan

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth

2011-12-02T23:26:25+00:00

Bluetooth: cmtp: Fix module reference

2011-11-21T16:28:45+00:00

We cannot call module_put(THIS_MODULE) if this is our last reference. Otherwise, this call may cleanup our module before it returns. Gladly, the kthread API provides a simple wrapper for us. So lets use module_put_and_exit() to avoid a race condition with the module cleanup code. Signed-off-by: David Herrmann Acked-by: Marcel Holtmann Signed-off-by: Gustavo F. Padovan

Bluetooth: replace list_for_each with list_for_each_entry whenever possible

2011-11-07T19:24:46+00:00

When all items in the list have the same type there is no much of a point to use list_for_each except if you want to use the list pointer itself. Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Gustavo F. Padovan

Bluetooth: Linearize skbs for use in BNEP, CMTP, HIDP, and RFCOMM

2011-09-27T21:15:55+00:00

Fragmented skbs are only encountered when receiving ERTM or streaming mode L2CAP data. BNEP, CMTP, HIDP, and RFCOMM generally use basic mode, but they need to handle fragments without crashing. Signed-off-by: Mat Martineau Signed-off-by: Gustavo F. Padovan