BMC/Intel-BMC/linux.git/net/batman-adv/routing.c, branch dev

batman-adv: Add required includes to all files

2015-06-07T15:07:19+00:00

The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: update copyright years for 2015

2015-05-29T08:13:35+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: fix misspelled words

2015-01-07T16:21:57+00:00

Reported-by: checkpatch Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: checkpatch - Please don't use multiple blank lines

2015-01-07T16:21:56+00:00

Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: fix and simplify condition when bonding should be used

2015-01-06T10:05:07+00:00

The current condition actually does NOT consider bonding when the interface the packet came in from is the soft interface, which is the opposite of what it should do (and the comment describes). Fix that and slightly simplify the condition. Reported-by: Ray Gibson Signed-off-by: Simon Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

batman-adv: remove unnecessary logspam

2014-08-05T07:41:54+00:00

This patch removes unnecessary logspam which resulted from superfluous calls to net_ratelimit(). With the supplied patch, net_ratelimit() is called after the loglevel has been checked. Signed-off-by: André Gaul Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

batman-adv: prefer ether_addr_copy to memcpy

2014-03-22T07:50:26+00:00

On some architectures ether_addr_copy() is slightly faster than memcpy() therefore use the former when possible. Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: free skb on TVLV parsing success

2014-02-17T16:17:02+00:00

When the TVLV parsing routine succeed the skb is left untouched thus leading to a memory leak. Fix this by consuming the skb in case of success. Introduced by ef26157747d42254453f6b3ac2bd8bd3c53339c3 ("batman-adv: tvlv - basic infrastructure") Reported-by: Russel Senior Signed-off-by: Antonio Quartulli Tested-by: Russell Senior Signed-off-by: Marek Lindner

batman-adv: properly check pskb_may_pull return value

2014-02-17T16:17:01+00:00

pskb_may_pull() returns 1 on success and 0 in case of failure, therefore checking for the return value being negative does not make sense at all. This way if the function fails we will probably read beyond the current skb data buffer. Fix this by doing the proper check. Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

2014-01-12T13:41:19+00:00

Signed-off-by: Simon Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli