BMC/Intel-BMC/linux.git/net/batman-adv/main.c, branch dev

batman-adv: Add required includes to all files

2015-06-07T15:07:19+00:00

The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: Remove unnecessary ret variable in algo_register

2015-06-03T13:57:25+00:00

Remove ret variable and all jumps. Signed-off-by: Markus Pargmann Signed-off-by: Marek Lindner

batman-adv: Remove unnecessary ret variable

2015-06-03T13:57:24+00:00

We can avoid this indirect return variable by directly returning the error values. Signed-off-by: Markus Pargmann Signed-off-by: Marek Lindner

batman-adv: main, Convert is_my_mac() to bool

2015-06-03T13:57:24+00:00

It is much clearer to see a bool type as return value than 'int' for functions that are supposed to return true or false. Signed-off-by: Markus Pargmann Signed-off-by: Marek Lindner

batman-adv: tvlv realloc, move error handling into if block

2015-05-29T08:13:36+00:00

Instead of hiding the normal function flow inside an if block, we should just put the error handling into the if block. Signed-off-by: Markus Pargmann Signed-off-by: Marek Lindner

batman-adv: update copyright years for 2015

2015-05-29T08:13:35+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: fix misspelled words

2015-01-07T16:21:57+00:00

Reported-by: checkpatch Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: clear control block of received socket buffers

2015-01-07T16:21:57+00:00

Since other network components (and some drivers) uses the control block provided in skb's, the network coding feature might wrongly assume that an SKB has been decoded, and thus not try to code it with another packet again. This happens for instance when batman-adv is running on a bridge device. Fix this by clearing the control block for every received SKB. Introduced by 3c12de9a5c756b23fe7c9ab332474ece1568914c ("batman-adv: network coding - code and transmit packets if possible") Signed-off-by: Martin Hundebøll Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

batman-adv: checkpatch - Please don't use multiple blank lines

2015-01-07T16:21:56+00:00

Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: kernel doc fixes for main.{c, h}

2015-01-07T16:21:54+00:00

Signed-off-by: Martin Hundebøll Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli