BMC/Intel-BMC/linux.git/net/batman-adv/gateway_client.c, branch dev

batman-adv: initialize up/down values when adding a gateway

2015-08-04T22:31:47+00:00

Without this initialization, gateways which actually announce up/down bandwidth of 0/0 could be added. If these nodes get purged via _batadv_purge_orig() later, the gw_node structure does not get removed since batadv_gw_node_delete() updates the gw_node with up/down bandwidth of 0/0, and the updating function then discards the change and does not free gw_node. This results in leaking the gw_node structures, which references other structures: gw_node -> orig_node -> orig_node_ifinfo -> hardif. When removing the interface later, the open reference on the hardif may cause hangs with the infamous "unregister_netdevice: waiting for mesh1 to become free. Usage count = 1" message. Signed-off-by: Simon Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

batman-adv: Remove unused post-VLAN ethhdr in batadv_gw_dhcp_recipient_get

2015-06-07T15:07:20+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: Add required includes to all files

2015-06-07T15:07:19+00:00

The header files could not be build indepdent from each other. This is happened because headers didn't include the files for things they've used. This was problematic because the success of a build depended on the knowledge about the right order of local includes. Also source files were not including everything they've used explicitly. Instead they required that transitive includes are always stable. This is problematic because some transitive includes are not obvious, depend on config settings and may not be stable in the future. The order for include blocks are: * primary headers (main.h and the *.h file of a *.c file) * global linux headers * required local headers * extra forward declarations for pointers in function/struct declarations The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h. This header file is shared with userspace applications like batctl and must therefore build together with userspace applications. The header linux/bitops.h is not part of the uapi headers and linux/if_ether.h conflicts with the musl implementation of netinet/if_ether.h. The maintainers rejected the use of __KERNEL__ preprocessor checks and thus these two headers are only in main.h. All files using packet.h first have to include main.h to work correctly. Reported-by: Markus Pargmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: update copyright years for 2015

2015-05-29T08:13:35+00:00

Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

batman-adv: Fix use of seq_has_overflowed()

2015-02-22T22:00:08+00:00

net-next commit 6d91147d183c ("batman-adv: Remove uses of return value of seq_printf") incorrectly changed the overflow occurred return from -1 to 1. Change it back so that the test of batadv_write_buffer_text's return value in batadv_gw_client_seq_print_text works properly. Signed-off-by: Joe Perches Signed-off-by: David S. Miller

batman-adv: Remove uses of return value of seq_printf

2015-02-20T20:18:26+00:00

This function is soon going to return void so remove the return value use. Convert the return value to test seq_has_overflowed() instead. Signed-off-by: Joe Perches Acked-by: Antonio Quartulli Signed-off-by: David S. Miller

batman-adv: checkpatch - Please use a blank line after declarations

2015-01-07T16:21:55+00:00

Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: avoid NULL dereferences and fix if check

2014-12-24T04:13:37+00:00

Gateway having bandwidth_down equal to zero are not accepted at all and so never added to the Gateway list. For this reason checking the bandwidth_down member in batadv_gw_out_of_range() is useless. This is probably a copy/paste error and this check was supposed to be "!gw_node" only. Moreover, the way the check is written now may also lead to a NULL dereference. Fix this by rewriting the if-condition properly. Introduced by 414254e342a0d58144de40c3da777521ebaeeb07 ("batman-adv: tvlv - gateway download/upload bandwidth container") Signed-off-by: Antonio Quartulli Reported-by: David Binderman Signed-off-by: Marek Lindner Signed-off-by: David S. Miller

batman-adv: increase orig refcount when storing ref in gw_node

2014-05-15T18:03:17+00:00

A pointer to the orig_node representing a bat-gateway is stored in the gw_node->orig_node member, but the refcount for such orig_node is never increased. This leads to memory faults when gw_node->orig_node is accessed and the originator has already been freed. Fix this by increasing the refcount on gw_node creation and decreasing it on gw_node free. Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner

batman-adv: prefer ether_addr_copy to memcpy

2014-03-22T07:50:26+00:00

On some architectures ether_addr_copy() is slightly faster than memcpy() therefore use the former when possible. Signed-off-by: Antonio Quartulli Signed-off-by: Marek Lindner