<feed xmlns='http://www.w3.org/2005/Atom'>
<title>BMC/Intel-BMC/linux.git/fs/nfs/client.c, branch dev</title>
<subtitle>Intel OpenBMC Linux kernel source tree (mirror)</subtitle>
<id>https://git.radix-linux.su/BMC/Intel-BMC/linux.git/atom?h=dev</id>
<link rel='self' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/atom?h=dev'/>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/'/>
<updated>2015-07-22T21:15:54+00:00</updated>
<entry>
<title>NFS: Remove the "NFS_CAP_CHANGE_ATTR" capability</title>
<updated>2015-07-22T21:15:54+00:00</updated>
<author>
<name>Trond Myklebust</name>
<email>trond.myklebust@primarydata.com</email>
</author>
<published>2015-07-05T15:12:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=cd812599796f500b042f5464b6665755eca21137'/>
<id>urn:sha1:cd812599796f500b042f5464b6665755eca21137</id>
<content type='text'>
Setting the change attribute has been mandatory for all NFS versions, since
commit 3a1556e8662c ("NFSv2/v3: Simulate the change attribute"). We should
therefore not have anything be conditional on it being set/unset.

Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>nfs: Use remove_proc_subtree() instead remove_proc_entry()</title>
<updated>2015-07-01T15:29:41+00:00</updated>
<author>
<name>Kinglong Mee</name>
<email>kinglongmee@gmail.com</email>
</author>
<published>2015-07-01T15:00:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=6a062a3687c20b80362b04e1ae7c9772d511977d'/>
<id>urn:sha1:6a062a3687c20b80362b04e1ae7c9772d511977d</id>
<content type='text'>
Thanks for Al Viro's comments of killing proc_fs_nfs completely.

Signed-off-by: Kinglong Mee &lt;kinglongmee@gmail.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>nfs: Remove unused argument in nfs_server_set_fsinfo()</title>
<updated>2015-07-01T15:29:10+00:00</updated>
<author>
<name>Kinglong Mee</name>
<email>kinglongmee@gmail.com</email>
</author>
<published>2015-07-01T03:55:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=71f81e51ee0dc6d523a5229096c32eca2ab58bbb'/>
<id>urn:sha1:71f81e51ee0dc6d523a5229096c32eca2ab58bbb</id>
<content type='text'>
Commit e38eb6506f "NFS: set_pnfs_layoutdriver() from nfs4_proc_fsinfo()"
have remove the using of mntfh from nfs_server_set_fsinfo().

Signed-off-by: Kinglong Mee &lt;kinglongmee@gmail.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>nfs: Fix showing truncated fsid/dev in, /proc/net/nfsfs/volumes</title>
<updated>2015-06-16T15:17:37+00:00</updated>
<author>
<name>Kinglong Mee</name>
<email>kinglongmee@gmail.com</email>
</author>
<published>2015-06-13T02:07:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=df05a49f7204d81ba0e29fda3d56ccb730f05d87'/>
<id>urn:sha1:df05a49f7204d81ba0e29fda3d56ccb730f05d87</id>
<content type='text'>
A truncated fsid showing from /proc/fs/nfsfs/volumes as,
NV SERVER   PORT DEV     FSID              FSC
v4 c0a80881  801 0:43    34931f044c2a439b  no

It should be as,
NV SERVER   PORT DEV          FSID                              FSC
v4 c0a80881  801 0:43         34931f044c2a439b:954c5d830fa4be8c no

The max buffer length for storing "%llx:%llx" format should be
 16 + 1 + 16 + 1 = 34 (16 for %llx, 1 for ':', 1 for '\0').

Also, for storing "%u:%u" of MAJOR() and MINOR() should be
 8 + 1 + 3 + 1 = 13 (8 for 2^24, 1 for ':', 3 for 2^8, 1 for '\0').

v2, add comments for dev/fsid buffer and use sizeof in snprintf.

Signed-off-by: Kinglong Mee &lt;kinglongmee@gmail.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>NFS: Remove CONFIG_NFS_V4 checks from nfs_idmap.h</title>
<updated>2015-04-23T19:16:13+00:00</updated>
<author>
<name>Anna Schumaker</name>
<email>Anna.Schumaker@netapp.com</email>
</author>
<published>2015-04-15T17:00:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=f9ebd61855253078fe8b07bacaf516337f8078e8'/>
<id>urn:sha1:f9ebd61855253078fe8b07bacaf516337f8078e8</id>
<content type='text'>
The idmapper is completely internal to the NFS v4 module, so this macro
will always evaluate to true.  This patch also removes unnecessary
includes of this file from the generic NFS client.

Signed-off-by: Anna Schumaker &lt;Anna.Schumaker@Netapp.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>NFSv4: Fix a race in NFSv4.1 server trunking discovery</title>
<updated>2015-03-04T01:42:23+00:00</updated>
<author>
<name>Trond Myklebust</name>
<email>trond.myklebust@primarydata.com</email>
</author>
<published>2015-03-04T01:28:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=48d66b9749e39e0d4cc37d635df3f18906af38a6'/>
<id>urn:sha1:48d66b9749e39e0d4cc37d635df3f18906af38a6</id>
<content type='text'>
We do not want to allow a race with another NFS mount to cause
nfs41_walk_client_list() to establish a lease on our nfs_client before
we're done checking for trunking.

Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>Merge branch 'bugfixes' into linux-next</title>
<updated>2014-09-30T21:21:41+00:00</updated>
<author>
<name>Trond Myklebust</name>
<email>trond.myklebust@primarydata.com</email>
</author>
<published>2014-09-30T21:21:41+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=72c23f0819977d37924af92a42a9b7fbfd1c95d8'/>
<id>urn:sha1:72c23f0819977d37924af92a42a9b7fbfd1c95d8</id>
<content type='text'>
* bugfixes:
  NFSv4.1: Fix an NFSv4.1 state renewal regression
  NFSv4: fix open/lock state recovery error handling
  NFSv4: Fix lock recovery when CREATE_SESSION/SETCLIENTID_CONFIRM fails
  NFS: Fabricate fscache server index key correctly
  SUNRPC: Add missing support for RPC_CLNT_CREATE_NO_RETRANS_TIMEOUT
  nfs: fix duplicate proc entries
</content>
</entry>
<entry>
<title>nfs: fix duplicate proc entries</title>
<updated>2014-09-25T03:00:18+00:00</updated>
<author>
<name>Fabian Frederick</name>
<email>fabf@skynet.be</email>
</author>
<published>2014-09-24T16:56:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=2f3169fb18f4643ac9a6a097a6a6c71f0b2cef75'/>
<id>urn:sha1:2f3169fb18f4643ac9a6a097a6a6c71f0b2cef75</id>
<content type='text'>
Commit 65b38851a174
("NFS: Fix /proc/fs/nfsfs/servers and /proc/fs/nfsfs/volumes")

updated the following function:
static int nfs_volume_list_open(struct inode *inode, struct file *file)

it used &amp;nfs_server_list_ops instead of &amp;nfs_volume_list_ops
which means cat /proc/fs/nfsfs/volumes = /proc/fs/nfsfs/servers

Signed-off-by: Fabian Frederick &lt;fabf@skynet.be&gt;
Fixes: 65b38851a174 (NFS: Fix /proc/fs/nfsfs/servers and...)
Cc: stable@vger.kernel.org # 3.4.x+
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>nfs: add __acquires and __releases annotations to seqfile start/stop routines</title>
<updated>2014-09-10T19:47:04+00:00</updated>
<author>
<name>Jeff Layton</name>
<email>jlayton@primarydata.com</email>
</author>
<published>2014-09-10T13:04:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=8d11620e1e43f829721aa1e76bd9dc2da079df9e'/>
<id>urn:sha1:8d11620e1e43f829721aa1e76bd9dc2da079df9e</id>
<content type='text'>
To make sparse happy...

Signed-off-by: Jeff Layton &lt;jlayton@primarydata.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
<entry>
<title>nfs: fix kernel warning when removing proc entry</title>
<updated>2014-09-08T23:41:36+00:00</updated>
<author>
<name>Cong Wang</name>
<email>xiyou.wangcong@gmail.com</email>
</author>
<published>2014-09-08T23:17:55+00:00</published>
<link rel='alternate' type='text/html' href='https://git.radix-linux.su/BMC/Intel-BMC/linux.git/commit/?id=21e81002f9788a3af591416b6dec60d7b67f2fb2'/>
<id>urn:sha1:21e81002f9788a3af591416b6dec60d7b67f2fb2</id>
<content type='text'>
I saw the following kernel warning:

[ 1852.321222] ------------[ cut here ]------------
[ 1852.326527] WARNING: CPU: 0 PID: 118 at fs/proc/generic.c:521 remove_proc_entry+0x154/0x16b()
[ 1852.335630] remove_proc_entry: removing non-empty directory 'fs/nfsfs', leaking at least 'volumes'
[ 1852.344084] CPU: 0 PID: 118 Comm: kworker/u8:2 Not tainted 3.16.0+ #540
[ 1852.350036] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[ 1852.354992] Workqueue: netns cleanup_net
[ 1852.358701]  0000000000000000 ffff880116f2fbd0 ffffffff819c03e9 ffff880116f2fc18
[ 1852.366474]  ffff880116f2fc08 ffffffff810744ee ffffffff811e0e6e ffff8800d4e96238
[ 1852.373507]  ffffffff81dbe665 ffff8800d46a5948 0000000000000005 ffff880116f2fc68
[ 1852.380224] Call Trace:
[ 1852.381976]  [&lt;ffffffff819c03e9&gt;] dump_stack+0x4d/0x66
[ 1852.385495]  [&lt;ffffffff810744ee&gt;] warn_slowpath_common+0x7a/0x93
[ 1852.389869]  [&lt;ffffffff811e0e6e&gt;] ? remove_proc_entry+0x154/0x16b
[ 1852.393987]  [&lt;ffffffff8107457b&gt;] warn_slowpath_fmt+0x4c/0x4e
[ 1852.397999]  [&lt;ffffffff811e0e6e&gt;] remove_proc_entry+0x154/0x16b
[ 1852.402034]  [&lt;ffffffff8129c73d&gt;] nfs_fs_proc_net_exit+0x53/0x56
[ 1852.406136]  [&lt;ffffffff812a103b&gt;] nfs_net_exit+0x12/0x1d
[ 1852.409774]  [&lt;ffffffff81785bc9&gt;] ops_exit_list+0x44/0x55
[ 1852.413529]  [&lt;ffffffff81786389&gt;] cleanup_net+0xee/0x182
[ 1852.417198]  [&lt;ffffffff81088c9e&gt;] process_one_work+0x209/0x40d
[ 1852.502320]  [&lt;ffffffff81088bf7&gt;] ? process_one_work+0x162/0x40d
[ 1852.587629]  [&lt;ffffffff810890c1&gt;] worker_thread+0x1f0/0x2c7
[ 1852.673291]  [&lt;ffffffff81088ed1&gt;] ? process_scheduled_works+0x2f/0x2f
[ 1852.759470]  [&lt;ffffffff8108e079&gt;] kthread+0xc9/0xd1
[ 1852.843099]  [&lt;ffffffff8109427f&gt;] ? finish_task_switch+0x3a/0xce
[ 1852.926518]  [&lt;ffffffff8108dfb0&gt;] ? __kthread_parkme+0x61/0x61
[ 1853.008565]  [&lt;ffffffff819cbeac&gt;] ret_from_fork+0x7c/0xb0
[ 1853.076477]  [&lt;ffffffff8108dfb0&gt;] ? __kthread_parkme+0x61/0x61
[ 1853.140653] ---[ end trace 69c4c6617f78e32d ]---

It looks wrong that we add "/proc/net/nfsfs" in nfs_fs_proc_net_init()
while remove "/proc/fs/nfsfs" in nfs_fs_proc_net_exit().

Fixes: commit 65b38851a17 (NFS: Fix /proc/fs/nfsfs/servers and /proc/fs/nfsfs/volumes)
Cc: Eric W. Biederman &lt;ebiederm@xmission.com&gt;
Cc: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
Cc: Dan Aloni &lt;dan@kernelim.com&gt;
Signed-off-by: Cong Wang &lt;xiyou.wangcong@gmail.com&gt;
[Trond: replace uses of remove_proc_entry() with remove_proc_subtree()
as suggested by Al Viro]
Cc: stable@vger.kernel.org # 3.4.x : 65b38851a17: NFS: Fix /proc/fs/nfsfs/servers
Cc: stable@vger.kernel.org # 3.4.x
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
</content>
</entry>
</feed>
