BMC/Intel-BMC/linux.git/fs/namei.c, branch dev

may_follow_link() should use nd->inode

2015-08-05T03:23:50+00:00

Now that we can get there in RCU mode, we shouldn't play with nd->path.dentry->d_inode - it's not guaranteed to be stable. Use nd->inode instead. Reported-by: Hugh Dickins Signed-off-by: Al Viro

link_path_walk(): be careful when failing with ENOTDIR

2015-08-02T00:18:38+00:00

In RCU mode we might end up with dentry evicted just we check that it's a directory. In such case we should return ECHILD rather than ENOTDIR, so that pathwalk would be retries in non-RCU mode. Breakage had been introduced in commit b18825a - prior to that we were looking at nd->inode, which had been fetched before verifying that ->d_seq was still valid. That form of check would only be satisfied if at some point the pathname prefix would indeed have resolved to a non-directory. The fix consists of checking ->d_seq after we'd run into a non-directory dentry, and failing with ECHILD in case of mismatch. Note that all branches since 3.12 have that problem... Signed-off-by: Al Viro

namei: make set_root_rcu() return void

2015-06-29T16:07:04+00:00

The only caller that cares about its return value can just as easily pick it from nd->root_seq itself. We used to just calculate it and return to caller, but these days we are storing it in nd->root_seq in all cases. Signed-off-by: Al Viro

turn user_{path_at,path,lpath,path_dir}() into static inlines

2015-05-15T05:10:45+00:00

Signed-off-by: Al Viro

namei: move saved_nd pointer into struct nameidata

2015-05-15T05:10:45+00:00

these guys are always declared next to each other; might as well put the former (pointer to previous instance) into the latter and simplify the calling conventions for {set,restore}_nameidata() Signed-off-by: Al Viro

inline user_path_create()

2015-05-15T05:10:44+00:00

Signed-off-by: Al Viro

inline user_path_parent()

2015-05-15T05:10:44+00:00

Signed-off-by: Al Viro

namei: trim do_last() arguments

2015-05-15T05:10:43+00:00

now that struct filename is stashed in nameidata we have no need to pass it in Signed-off-by: Al Viro

namei: stash dfd and name into nameidata

2015-05-15T05:10:43+00:00

fewer arguments to pass around... Signed-off-by: Al Viro

namei: fold path_cleanup() into terminate_walk()

2015-05-15T05:10:42+00:00

they are always called next to each other; moreover, terminate_walk() is more symmetrical that way. Signed-off-by: Al Viro