BMC/Intel-BMC/linux.git/drivers/usb/serial/keyspan.c, branch dev-4.6

USB: serial: keyspan: fix use-after-free in probe error path

2016-06-01T19:18:01+00:00

commit 35be1a71d70775e7bd7e45fa6d2897342ff4c9d2 upstream. The interface instat and indat URBs were submitted in attach, but never unlinked in release before deallocating the corresponding transfer buffers. In the case of a late probe error (e.g. due to failed minor allocation), disconnect would not have been called before release, causing the buffers to be freed while the URBs are still in use. We'd also end up with active URBs for an unbound interface. Fixes: f9c99bb8b3a1 ("USB: usb-serial: replace shutdown with disconnect, release") Signed-off-by: Johan Hovold Acked-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman

USB: serial: fix semicolon.cocci warnings

2016-02-28T13:36:53+00:00

Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Mathieu OTHACEHE Signed-off-by: Johan Hovold

USB: keyspan: fix null-deref at probe

2015-01-02T14:12:28+00:00

Fix null-pointer dereference during probe if the interface-status completion handler is called before the individual ports have been set up. Fixes: f79b2d0fe81e ("USB: keyspan: fix NULL-pointer dereferences and memory leaks") Reported-by: Richard Tested-by: Richard Cc: stable Signed-off-by: Johan Hovold

USB: keyspan: fix overrun-error reporting

2014-11-19T15:22:22+00:00

Fix reporting of overrun errors, which are not associated with a character. Instead insert a null character and report only once. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold

USB: keyspan: fix tty line-status reporting

2014-11-19T15:22:21+00:00

Fix handling of TTY error flags, which are not bitmasks and must specifically not be ORed together as this prevents the line discipline from recognising them. Also insert null characters when reporting overrun errors as these are not associated with the received character. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold

USB: keyspan: fix potential null pointer dereference

2014-05-27T22:14:13+00:00

Move control-urb dereference to after NULL-check. There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. [Johan: modify commit message somewhat ] [gkh: remove stable tag as it's not a real problem that anyone has ever hit] Signed-off-by: Rickard Strandqvist Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

USB: keyspan: remove dead debugging code

2014-03-12T19:44:50+00:00

Remove out-commented and ifdeffed debugging code. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

usb: delete non-required instances of include

2014-01-08T23:01:39+00:00

None of these files are actually using any __init type directives and hence don't need to include . Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker Signed-off-by: Greg Kroah-Hartman

USB: serial: correct spelling mistakes in comments

2014-01-03T20:39:31+00:00

Signed-off-by: Rahul Bedarkar Signed-off-by: Greg Kroah-Hartman

USB: serial: remove redundant OOM messages

2014-01-03T20:31:46+00:00

Remove redundant error messages on allocation failures, which have already been logged. Cc: Joe Perches Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman