BMC/Intel-BMC/linux.git/drivers/usb/serial/io_ti.c, branch dev-5.14-intel

USB: serial: make usb_serial_driver::chars_in_buffer return uint

2021-05-19T08:56:41+00:00

tty_operations::chars_in_buffer is being switched to return uint. Do the same for usb_serial_driver's chars_in_buffer. Signed-off-by: Jiri Slaby [ johan: amend commit message ] Signed-off-by: Johan Hovold

USB: serial: make usb_serial_driver::write_room return uint

2021-05-19T08:56:40+00:00

Line disciplines expect a positive value or zero returned from tty->ops->write_room (invoked by tty_write_room). Both of them are being updated to return an unsigned int. Switch also usb_serial_driver::write_room and all its users. Signed-off-by: Jiri Slaby [ johan: amend commit message, drop unrelated comment change ] Signed-off-by: Johan Hovold

USB: serial: io_ti: drop unnecessary packed attributes

2021-04-13T16:23:34+00:00

Drop unnecessary packed attributes from structures that don't need it and use the __packed macro consistently. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: use kernel types consistently

2021-04-13T16:23:29+00:00

Use kernel types consistently by replacing the remaining __uXX types. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: add read-port-command helper

2021-04-13T16:23:29+00:00

Add a read-port-command helper analogous to the send-port-command helper to take care of the UART module id instead of open coding. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: add send-port-command helper

2021-04-13T16:23:26+00:00

Add a send-port-command helper which takes care of determining the UART module id when sending commands instead of doing so at every call site. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: clean up vendor-request helpers

2021-04-13T16:23:24+00:00

Clean up the vendor-request helpers by using kernel-types consistently and using void pointers for the data arguments, which allows removing a cast from one caller. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: document reason for drain delay

2021-04-13T16:19:32+00:00

Document that the device line-status register doesn't tell when the transmitter shift register has emptied and that this is why the one-character drain delay is needed. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: switch to 30-second closing wait

2021-04-08T07:49:34+00:00

Switch to using the system-wide default 30-second closing-wait timeout instead of the driver specific 40-second timeout. The timeout can be changed per port using TIOCSSERIAL (setserial) if needed. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold

USB: serial: io_ti: drop closing_wait module parameter

2021-04-08T07:49:33+00:00

Now that all USB serial drivers supports setting the closing_wait parameter through TIOCSSERIAL (setserial) it's time to drop the corresponding io_ti module parameter. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold