BMC/Intel-BMC/linux.git/drivers/tty/serial/xilinx_uartps.c, branch dev-5.2Intel OpenBMC Linux kernel source tree (mirror)https://git.radix-linux.su/BMC/Intel-BMC/linux.git/atom?h=dev-5.22019-07-31T05:24:41+00:00serial: uartps: Use the same dynamic major number for all ports2019-07-31T05:24:41+00:00Shubhrajyoti Dattashubhrajyoti.datta@xilinx.com2019-06-12T11:14:38+00:00urn:sha1:c9712e3338098359a82c3f5d198c92688fa6cd26
[ Upstream commit ab262666018de6f4e206b021386b93ed0c164316 ]
Let kernel to find out major number dynamically for the first device and
then reuse it for other instances.
This fixes the issue that each uart is registered with a
different major number.
After the patch:
crw------- 1 root root 253, 0 Jun 10 08:31 /dev/ttyPS0
crw--w---- 1 root root 253, 1 Jan 1 1970 /dev/ttyPS1
Fixes: 024ca329bfb9 ("serial: uartps: Register own uart console and driver structures")
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
serial: uartps: Add support for cts-override2019-04-29T14:20:24+00:00Shubhrajyoti Dattashubhrajyoti.datta@xilinx.com2019-04-09T07:45:24+00:00urn:sha1:1863178b20c5add7e6d217f2bf6d094ff13660f7
Having flow is configurable. Add support for the same by
checking for cts-override.
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tty: xilinx_uartps: Correct return value in probe2019-03-01T17:07:34+00:00Rajan Vajarajan.vaja@xilinx.com2019-03-01T09:37:08+00:00urn:sha1:f694936c3b5a4c140ded5b673555d95aedc866b9
Existing driver checks for alternate clock if devm_clk_get() fails
and returns error code for last clock failure. If xilinx_uartps is
called before clock driver, devm_clk_get() returns -EPROBE_DEFER.
In this case, probe should not check for alternate clock as main
clock is already present in DTS and return -EPROBE_DEFER only.
This patch fixes it by not checking for alternate clock when main
clock get returns -EPROBE_DEFER.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
serial: uartps: Fix stuck ISR if RX disabled with non-empty FIFO2019-02-19T12:42:07+00:00Anssi Hannulaanssi.hannula@bitwise.fi2019-02-15T16:45:08+00:00urn:sha1:7abab1605139bc41442864c18f9573440f7ca105
If RX is disabled while there are still unprocessed bytes in RX FIFO,
cdns_uart_handle_rx() called from interrupt handler will get stuck in
the receive loop as read bytes will not get removed from the RX FIFO
and CDNS_UART_SR_RXEMPTY bit will never get set.
Avoid the stuck handler by checking first if RX is disabled. port->lock
protects against race with RX-disabling functions.
This HW behavior was mentioned by Nathan Rossi in 43e98facc4a3 ("tty:
xuartps: Fix RX hang, and TX corruption in termios call") which fixed a
similar issue in cdns_uart_set_termios().
The behavior can also be easily verified by e.g. setting
CDNS_UART_CR_RX_DIS at the beginning of cdns_uart_handle_rx() - the
following loop will then get stuck.
Resetting the FIFO using RXRST would not set RXEMPTY either so simply
issuing a reset after RX-disable would not work.
I observe this frequently on a ZynqMP board during heavy RX load at 1M
baudrate when the reader process exits and thus RX gets disabled.
Fixes: 61ec9016988f ("tty/serial: add support for Xilinx PS UART")
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
serial: uartps: Fix interrupt mask issue to handle the RX interrupts properly2018-12-19T07:23:20+00:00Nava kishore Mannenava.manne@xilinx.com2018-12-18T12:18:42+00:00urn:sha1:260683137ab5276113fc322fdbbc578024185fee
This patch Correct the RX interrupt mask value to handle the
RX interrupts properly.
Fixes: c8dbdc842d30 ("serial: xuartps: Rewrite the interrupt handling logic")
Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
serial: uartps: Fix error path when alloc failed2018-12-19T07:23:20+00:00Michal Simekmichal.simek@xilinx.com2018-12-18T12:18:41+00:00urn:sha1:32cf21ac4edd6c0d5b9614368a83bcdc68acb031
When cdns_uart_console allocation failed there is a need to also clear
ID from ID list.
Fixes: ae1cca3fa347 ("serial: uartps: Change uart ID port allocation")
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
serial: uartps: Check if the device is a console2018-12-19T07:23:20+00:00Shubhrajyoti Dattashubhrajyoti.datta@xilinx.com2018-12-18T12:18:40+00:00urn:sha1:82b1b2ec5d4057af11395ac03209884369418a0d
While checking for console_suspend_enabled also check if the
device is a console.
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
serial: uartps: Add the device_init_wakeup2018-12-19T07:23:20+00:00Shubhrajyoti Dattashubhrajyoti.datta@xilinx.com2018-12-18T12:18:39+00:00urn:sha1:86df8dd147233fd1705b9f7a8541d1501d4c5295
Initialise the device wakeup.
The device_init_wakeup is needed for the wakeup to work by default.
Uart can be configured as the primary wakeup source so it is good to
enable wakeup by default.
The same functionality is enabled also by 8250_omap, atmel_serial,
omap-serial and stm32-usart.
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Revert "tty: xilinx_uartps: Correct return value in probe"2018-12-06T11:47:22+00:00Greg Kroah-Hartmangregkh@linuxfoundation.org2018-12-06T11:47:22+00:00urn:sha1:82ca0d5487d4e1444b05d9f73757b395c1228bba
This reverts commit eca42d4cf3c591c36312c52707e0a712e0c7256a.
During review it was rejected, so drop it from the tree.
Cc: Rajan Vaja <RAJANV@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tty: xilinx_uartps: Correct return value in probe2018-12-05T10:02:38+00:00Rajan Vajarajan.vaja@xilinx.com2018-12-04T12:51:22+00:00urn:sha1:eca42d4cf3c591c36312c52707e0a712e0c7256a
Existing driver checks for alternate clock if devm_clk_get() fails
and returns error code for last clock failure. If xilinx_uartps is
called before clock driver, devm_clk_get() returns -EPROBE_DEFER.
In this case, probe should not check for alternate clock as main
clock is already present in DTS and return -EPROBE_DEFER only.
This patch fixes it by not checking for alternate clock when main
clock get returns -EPROBE_DEFER.
Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>