BMC/Intel-BMC/linux.git/drivers/tty/serial/imx.c, branch dev-5.2

serial: imx: fix locking in set_termios()

2019-07-31T05:24:40+00:00

[ Upstream commit 4e828c3e09201512be5ee162393f334321f7cf01 ] imx_uart_set_termios() called imx_uart_rts_active(), or imx_uart_rts_inactive() before taking port->port.lock. As a consequence, sport->port.mctrl that these functions modify could have been changed without holding port->port.lock. Moved locking of port->port.lock above the calls to fix the issue. Signed-off-by: Sergey Organov Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin

serial: imx: remove log spamming error message

2019-05-21T10:18:17+00:00

Each time the DMA engine signals a transaction error the driver prints a message at error level. Getting transaction errors is pretty much expected on baudrate mismatches and the correspoding error counters are increased in this case properly. Remove the error message which is possibly repeated at a very high rate which can lock up the whole system. Signed-off-by: Sascha Hauer Reviewed-by: Fabio Estevam Signed-off-by: Greg Kroah-Hartman

serial: imx: fix error handling in console_setup

2018-11-27T08:56:20+00:00

The ipg clock only needs to be unprepared in case preparing per clock fails. The ipg clock has already disabled at the point. Fixes: 1cf93e0d5488 ("serial: imx: remove the uart_console() check") Signed-off-by: Stefan Agner Reviewed-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman

Merge 4.19-rc6 into tty-next

2018-09-30T15:11:09+00:00

We want the tty/serial fixes in here as well. Signed-off-by: Greg Kroah-Hartman

serial: imx: restore handshaking irq for imx1

2018-09-20T12:51:31+00:00

Back in 2015 when irda was dropped from the driver imx1 was broken. This change reintroduces the support for the third interrupt of the UART. Fixes: afe9cbb1a6ad ("serial: imx: drop support for IRDA") Cc: stable Signed-off-by: Uwe Kleine-König Reviewed-by: Leonard Crestez Signed-off-by: Greg Kroah-Hartman

tty: serial: imx: add pinctrl sleep/default mode switch for suspend

2018-09-18T14:07:24+00:00

On some i.MX SoCs' low power mode, such as i.MX7D's LPSR(low power state retention), UART iomux settings will be lost, need to add pinctrl sleep/default mode switch during suspend/resume to make sure UART iomux settings are correct after resume. Signed-off-by: Anson Huang Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman

tty: serial: imx: add lock for registers save/restore

2018-09-18T14:07:24+00:00

In noirq suspend/resume stage with no_console_suspend enabled, imx_uart_console_write() may be called to print out log_buf message by printk(), so there will be race condition between imx_uart_console_write() and imx_uart_save/restore_context(), need to add lock to protect the registers save/restore operations. Signed-off-by: Anson Huang Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman

tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-09-18T14:07:24+00:00

Before the program enters the uart ISR, the local interrupt has been disabled by the system, so it's not appropriate to use spin_lock_irqsave interface in the ISR. Signed-off-by: jun qian Reviewed-by: Barry Song <21cnbao@gmail.com> Signed-off-by: Greg Kroah-Hartman

tty: serial: imx: correct dma cookie status

2018-06-28T12:02:38+00:00

Correct to check the right rx dma cookie status in spit of it works because only one cookie is running in the current sdma. But it will not once sdma driver support multi cookies running based on virt-dma. Signed-off-by: Robin Gong Reviewed-by: Sascha Hauer Acked-by: Uwe Kleine-König Tested-by: Lucas Stach Signed-off-by: Greg Kroah-Hartman

serial: imx: fix comment about UCR2_SRST and its handling for shadowing

2018-06-28T12:02:38+00:00

Initially when register shadowing was introduced (commit 3a0ab62f43de ("serial: imx: implement shadow registers for UCRx and UFCR")) the logic to handle UCR2_SRST was wrong but documented consistently. Later the handling was fixed, but the comment was not. This change makes up leeway for the latter. Fixes: 0aa821d846c0 ("serial: imx: fix cached UCR2 read on software reset") Signed-off-by: Uwe Kleine-König Reviewed-by: Stefan Agner Signed-off-by: Greg Kroah-Hartman