BMC/Intel-BMC/linux.git/drivers/tty/serial/imx.c, branch dev-4.19

serial: imx: restore handshaking irq for imx1

2018-09-20T12:51:31+00:00

Back in 2015 when irda was dropped from the driver imx1 was broken. This change reintroduces the support for the third interrupt of the UART. Fixes: afe9cbb1a6ad ("serial: imx: drop support for IRDA") Cc: stable Signed-off-by: Uwe Kleine-König Reviewed-by: Leonard Crestez Signed-off-by: Greg Kroah-Hartman

tty: serial: imx: correct dma cookie status

2018-06-28T12:02:38+00:00

Correct to check the right rx dma cookie status in spit of it works because only one cookie is running in the current sdma. But it will not once sdma driver support multi cookies running based on virt-dma. Signed-off-by: Robin Gong Reviewed-by: Sascha Hauer Acked-by: Uwe Kleine-König Tested-by: Lucas Stach Signed-off-by: Greg Kroah-Hartman

serial: imx: fix comment about UCR2_SRST and its handling for shadowing

2018-06-28T12:02:38+00:00

Initially when register shadowing was introduced (commit 3a0ab62f43de ("serial: imx: implement shadow registers for UCRx and UFCR")) the logic to handle UCR2_SRST was wrong but documented consistently. Later the handling was fixed, but the comment was not. This change makes up leeway for the latter. Fixes: 0aa821d846c0 ("serial: imx: fix cached UCR2 read on software reset") Signed-off-by: Uwe Kleine-König Reviewed-by: Stefan Agner Signed-off-by: Greg Kroah-Hartman

serial: imx: disable UCR4_OREN on shutdown

2018-05-25T15:54:43+00:00

UCR4_OREN is (depending on the configuration) enabled in startup, but is never disabled. Fix this by disabling it in shutdown. Reported-by: Nandor Han Signed-off-by: Sebastian Reichel Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman

serial: imx: drop CTS/RTS handling from shutdown

2018-05-25T15:54:42+00:00

According to Documentation/serial/driver the shutdown function should not disable RTS, so drop it. Suggested-by: Uwe Kleine-König Signed-off-by: Sebastian Reichel Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman

serial: imx: dma_unmap_sg buffers on shutdown

2018-05-14T11:48:28+00:00

This properly unmaps DMA SG on device shutdown. Reported-by: Nandor Han Suggested-by: Nandor Han Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman

serial: imx: cleanup imx_uart_disable_dma()

2018-05-14T11:48:28+00:00

Remove unrelated CTSC/CTS disabling from imx_uart_disable_dma() and move it to imx_uart_shutdown(), which is the only user of the DMA disabling function. This should not change the driver's behaviour, but improves readability. After this change imx_uart_disable_dma() does the reverse thing of imx_uart_enable_dma(). Suggested-by: Nandor Han Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman

Merge 4.17-rc3 into tty-next

2018-04-30T12:14:55+00:00

We want the tty and serial driver fixes in here as well. Signed-off-by: Greg Kroah-Hartman

serial: imx: fix cached UCR2 read on software reset

2018-04-23T07:53:36+00:00

To reset the UART the SRST needs be cleared (low active). According to the documentation the bit will remain active for 4 module clocks until it is cleared (set to 1). Hence the real register need to be read in case the cached register indicates that the SRST bit is zero. This bug lead to wrong baudrate because the baud rate register got restored before reset completed in imx_flush_buffer. Fixes: 3a0ab62f43de ("serial: imx: implement shadow registers for UCRx and UFCR") Signed-off-by: Stefan Agner Reviewed-by: Fabio Estevam Reviewed-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman

serial: imx: warn user when using unsupported configuration

2018-04-23T07:53:36+00:00

When using half-duplex mode (which disables receiver during txing) the RTS signal cannot be driven low during transmission when using i.MX UART RTS/CTS control. This seems to be a limitation of the i.MX UART IP: The RTS (CTS_B) signal is controlled by the receiver. When the receiver is disabled, the signal stays in UART logic idle state which is high... If SER_RS485_RTS_ON_SEND is used, RTS needs to be high active during transmission. Since this is the default state of the RTS (CTS_B) signal when the receiver is off, half-duplex mode in this configuration works fine. However, a low-active RTS signal (flag SER_RS485_RTS_ON_SEND not set) cannot be generated when the receiver is turned off. Print an error if the user selects this unsupported configuration (both SER_RS485_RTS_ON_SEND and SER_RS485_RX_DURING_TX unset) and configure the closest working configuration (set the SER_RS485_RX_DURING_TX flag). Signed-off-by: Stefan Agner Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman