BMC/Intel-BMC/linux.git/drivers/thunderbolt/eeprom.c, branch dev-4.6

thunderbolt: Fix double free of drom buffer

2016-06-01T19:18:04+00:00

commit 2ffa9a5d76a75abbc1f95c17959fced666095bdd upstream. If tb_drom_read() fails, sw->drom is freed but not set to NULL. sw->drom is then freed again in the error path of tb_switch_alloc(). The bug can be triggered by unplugging a thunderbolt device shortly after it is detected by the thunderbolt driver. Clear sw->drom if tb_drom_read() fails. [bhelgaas: add Fixes:, stable versions of interest] Fixes: 343fcb8c70d7 ("thunderbolt: Fix nontrivial endpoint devices.") Signed-off-by: Andreas Noever Signed-off-by: Bjorn Helgaas CC: Lukas Wunner Signed-off-by: Greg Kroah-Hartman

thunderbolt: Make tb_eeprom_get_drom_offset static

2014-06-20T20:06:01+00:00

tb_eeprom_get_drom_offset is local to this file. Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Make enum tb_drom_entry_type unsigned

2014-06-20T20:06:01+00:00

Force enum tb_drom_entry_type to unsigned to fix the following error: drivers/thunderbolt/eeprom.c:202:39: error: dubious one-bit signed bitfield Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: fix format string for size_t

2014-06-20T16:46:36+00:00

The result of "sizeof(struct tb_drom_entry_port)" is a size_t, which is not necessarily the same as 'long', so we should use the appropriate %z format string instead of %l. Signed-off-by: Arnd Bergmann Acked-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Fix build error in eeprom.c

2014-06-20T16:44:42+00:00

Fixes the below error: drivers/thunderbolt/eeprom.c:407:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration] drivers/thunderbolt/eeprom.c:444:2: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration] Signed-off-by: Sachin Kamat Acked-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Read port configuration from eeprom.

2014-06-19T21:14:35+00:00

All Thunderbolt switches (except the root switch) contain a drom which contains information about the device. Right now we only read the UID. Add code to read and parse this drom. For now we are only interested in which ports are disabled and which ports are "dual link ports" (a physical thunderbolt port/socket contains two such ports). Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Read switch uid from EEPROM

2014-06-19T21:13:00+00:00

Add eeprom access code and read the uid during switch initialization. The UID will be used to check device identity after suspend. Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman