BMC/Intel-BMC/linux.git/drivers/rtc/rtc-xgene.c, branch dev-5.2Intel OpenBMC Linux kernel source tree (mirror)https://git.radix-linux.su/BMC/Intel-BMC/linux.git/atom?h=dev-5.22019-04-04T08:07:08+00:00rtc: xgene: use .set_time2019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:33+00:00urn:sha1:58f889150a665426495abf2d294708f3576738ff
Use .set_time instead of the deprecated .set_mmss.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: switch to rtc_time64_to_tm/rtc_tm_to_time642019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:32+00:00urn:sha1:43f327fa48480af31678576513458f4a5e66a3f6
Call the 64bit versions of rtc_tm time conversion as the range is enforced
by the core.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: stop caching alarm_time2019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:31+00:00urn:sha1:9a842a7ebb169c2a8d8b9a3489d8cacfc235f6bf
There is no point in caching alarm_time for .read_alarm because
.read_alarm is only called at boo time and thus alarm_time is always 0.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: correct checkpatch issues2019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:30+00:00urn:sha1:db7853414b3eb8fbd16017edd3d60e6f717170ff
Correct trivial whitespace issues. Also sort the headers.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: convert to SPDX identifier2019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:29+00:00urn:sha1:3a205b9dc87de108e096ac128e49feda9e3e58a8
Use SPDX-License-Identifier instead of a verbose license text.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: set range2019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:28+00:00urn:sha1:490595abfd36f29fbff9cb940531f1a7c58dd489
CCVR is a 32bit second counter.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: fix possible race condition2019-04-04T08:07:08+00:00Alexandre Bellonialexandre.belloni@bootlin.com2019-03-20T12:32:27+00:00urn:sha1:a652e00ee1233e251a337c28e18a1da59224e5ce
The IRQ is requested before the struct rtc is allocated and registered, but
this struct is used in the IRQ handler. This may lead to a NULL pointer
dereference.
Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc
struct before requesting the IRQ.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: stop validating rtc_time after rtc_time_to_tm2018-03-01T09:49:41+00:00Alexandre Bellonialexandre.belloni@bootlin.com2018-02-19T15:23:55+00:00urn:sha1:ab62670e57174c547abbecacf6df78d3dcf03f26
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: xgene: mark PM functions as __maybe_unused2017-11-09T00:25:47+00:00Arnd Bergmannarnd@arndb.de2017-11-08T12:08:10+00:00urn:sha1:573e2bf05421d0dc69dc3c604f286b3473d2f2cd
The new xgene_rtc_alarm_irq_enabled() function is only accessed
from PM code, which is inside of an #ifdef; this causes a harmless
build warning when CONFIG_PM is disabled:
drivers/rtc/rtc-xgene.c:108:12: error: 'xgene_rtc_alarm_irq_enabled' defined but not used [-Werror=unused-function]
Just remove the #ifdef and use __maybe_unused annotations instead,
to make the code more robust here.
Fixes: d0bcd82b1379 ("rtc: xgene: Fix suspend/resume")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Loc Ho <lho@apm.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
rtc: xgene: Fix suspend/resume2017-11-09T00:16:36+00:00Loc Holho@apm.com2014-04-14T18:09:04+00:00urn:sha1:d0bcd82b13794c4bc89876e9383000fc1cb069d2
This patch fixes suspend/resume functions properly for the APM X-Gene
SoC RTC driver.
Signed-off-by: Loc Ho <lho@apm.com>
Reviewed-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>