BMC/Intel-BMC/linux.git/drivers/pcmcia/yenta_socket.c, branch dev

pcmcia: Fix resource leaks in yenta_probe() and _close()

2015-06-14T19:35:45+00:00

There are some resource leaks in yenta_probe() and _close(). I fixed the following issues with some code cleanups. Thanks to Dominik's suggestions. On the error path in yenta_probe(): - a requested irq is not released - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called In yenta_close(): - kfree(sock) is not called - sock->base is always set to non-NULL when yenta_close() is called, therefore the check in yenta_close() is not necessary. Signed-off-by: Takeshi Yoshimura Signed-off-by: Dominik Brodowski

pcmcia: Convert dev_printk to dev_

2015-05-30T14:09:04+00:00

Reduce object size a little by using dev_ calls instead of dev_printk(KERN_. Other miscellanea: o Coalesce formats o Realign arguments o Use pr_cont instead of naked printk reorder test to use "%s\n" Signed-off-by: Joe Perches Signed-off-by: Dominik Brodowski

pcmcia: Use setup_timer and mod_timer

2015-03-16T20:31:43+00:00

This patch introduces the use of functions setup_timer and mod_timer. This is done using Coccinelle and semantic patch used for this as follows: // @@ expression x,y,z,a,b; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar Signed-off-by: Greg Kroah-Hartman

pcmcia: remove DEFINE_PCI_DEVICE_TABLE usage

2014-07-18T23:58:07+00:00

It's not needed, just use the "real" structure definition instead. Signed-off-by: Greg Kroah-Hartman

pcmcia: Use list_for_each_entry() for bus traversal

2014-02-14T18:20:51+00:00

Replace list_for_each() + pci_bus_b() with list_for_each_entry(). [bhelgaas: fix "silbling" typo] Signed-off-by: Yijing Wang Signed-off-by: Bjorn Helgaas

PCI: Convert pcibios_resource_to_bus() to take a pci_bus, not a pci_dev

2013-12-21T17:06:10+00:00

These interfaces: pcibios_resource_to_bus(struct pci_dev *dev, *bus_region, *resource) pcibios_bus_to_resource(struct pci_dev *dev, *resource, *bus_region) took a pci_dev, but they really depend only on the pci_bus. And we want to use them in resource allocation paths where we have the bus but not a device, so this patch converts them to take the pci_bus instead of the pci_dev: pcibios_resource_to_bus(struct pci_bus *bus, *bus_region, *resource) pcibios_bus_to_resource(struct pci_bus *bus, *resource, *bus_region) In fact, with standard PCI-PCI bridges, they only depend on the host bridge, because that's the only place address translation occurs, but we aren't going that far yet. [bhelgaas: changelog] Signed-off-by: Yinghai Lu Signed-off-by: Bjorn Helgaas

drivers/pcmcia/yenta_socket.c: convert to module_pci_driver

2013-09-26T15:56:34+00:00

Use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen Cc: Dominik Brodowski Cc: Bill Pemberton Cc: Greg Kroah-Hartman Cc: Eric Miao Cc: Bjorn Helgaas Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman

pcmcia: remove use of __devexit

2012-11-28T20:10:16+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton Signed-off-by: Greg Kroah-Hartman

pcmcia: remove use of __devinit

2012-11-28T20:10:16+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton Cc: Eric Miao Cc: Russell King Cc: Haojian Zhuang Acked-by: Eric Miao Signed-off-by: Greg Kroah-Hartman

pcmcia: remove use of __devexit_p

2012-11-28T20:10:16+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Signed-off-by: Bill Pemberton Signed-off-by: Greg Kroah-Hartman