BMC/Intel-BMC/linux.git/drivers/net/wireless/quantenna, branch dev-4.17

qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

2018-08-03T05:47:58+00:00

[ Upstream commit 3763770044640caeb1101cdea40697cc0814403c ] In case memory resources for fw were succesfully allocated, release them before jumping to fw_load_fail. Addresses-Coverity-ID: 1466092 ("Resource leak") Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") Signed-off-by: Gustavo A. R. Silva Reviewed-by: Sergey Matyukevich Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman

qtnfmac: fix invalid STA state on EAPOL failure

2018-08-03T05:47:41+00:00

[ Upstream commit 480daa9cb62c14bbd1b87a01cd9bc10cc56dbf32 ] Driver switches vif sta_state into QTNF_STA_CONNECTING when cfg80211 core initiates connect procedure. Further this state is changed either to QTNF_STA_CONNECTED or to QTNF_STA_DISCONNECTED by BSS_JOIN and BSS_LEAVE events from firmware. However it is possible that no such events will be sent by firmware, e.g. if EAPOL timed out. In this case vif sta_mode will remain in QTNF_STA_CONNECTING state and all subsequent connection attempts will fail with -EBUSY error code. Fix this by perfroming STA state transition from QTNF_STA_CONNECTING to QTNF_STA_DISCONNECTED in cfg80211 disconnect callback. No need to rely upon firmware events in this case. Signed-off-by: Sergey Matyukevich Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman

net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

2018-03-13T16:52:25+00:00

Lots of the wireless driver vendor Kconfig symol help text says "questions about cards." (2 spaces between "about" and "cards") Besides dropping one of those spaces, it also needs some other word inserted there. Instead of putting each vendor's name there, I chose to say "these" cards in all of the Kconfig help text. Cc: Kalle Valo Signed-off-by: Randy Dunlap Signed-off-by: Kalle Valo

qtnfmac: implement asynchronous firmware loading

2018-02-27T16:18:43+00:00

In pci probe() function start firmware loading, protocol handshake and driver core initialization, and not wait for completion. Signed-off-by: Sergei Maksimenko Signed-off-by: Kalle Valo

qtnfmac: enable reloading of qtnfmac kernel modules

2018-02-27T16:18:43+00:00

This patch enables rmmod/insmod for qtnfmac kernel modules: - do not 'pin' pci device in order to disable it on module unload - implement card reset procedure - restore PCI bar addresses for restarted wireless card Signed-off-by: Sergei Maksimenko Signed-off-by: Sergey Matyukevich Signed-off-by: Kalle Valo

qtnfmac: fix releasing Tx/Rx data buffers

2018-02-27T16:18:42+00:00

Add missing PCI unmap for Tx buffers and release all buffers explicitly. Managed release using devm_add_action is not suitable for qtnfmac Tx/Rx data buffers. The reason is in ordering and dependencies: buffers should be released after transmission is stopped but before PCI device resources and DMA allocations are released. Signed-off-by: Sergey Matyukevich Signed-off-by: Kalle Valo

qtnfmac: remove redundant 'unlikely' checks

2018-01-24T16:01:02+00:00

Signed-off-by: Sergey Matyukevich Signed-off-by: Kalle Valo

qtnfmac: do not use bus mutex for events processing

2018-01-24T16:00:55+00:00

Events processing requires locking of bus mutex, which is also used by cfg80211 layer before calling several of cfg80211 callbacks. Since all cfg80211 callbacks in qtnfmac driver also lock bus mutex, this potentially may lead to a deadlock. Do not use bus lock for event processing. Use RTNL lock instead to serialize events and commands processing threads. Signed-off-by: Igor Mitsyanko Signed-off-by: Kalle Valo

qtnfmac: do not use mutexes in timer context

2018-01-24T16:00:54+00:00

The function qtnf_scan_done makes use of mutexes which is wrong since it may be called from timer context. Move scan timeout handler from timer to deferred work. Signed-off-by: Igor Mitsyanko Signed-off-by: Kalle Valo

qtnfmac: fix STA disconnect procedure

2018-01-24T16:00:50+00:00

STA does not reconnect to the same AP after disconnect. The reason is that STA is marked as disconnected in cfg80211 disconnect callback. This is too early since in this case qtnfmac event handler skips cfg80211_disconnected call when processing disconnect event from the card. As a result, wdev is left in an inconsistent state. Signed-off-by: Sergey Matyukevich Signed-off-by: Kalle Valo