BMC/Intel-BMC/linux.git/drivers/net/wan/lapbether.c, branch dev-5.14-intel

net: lapbether: fix the code style issue about line length

2021-06-09T21:02:58+00:00

According to the chackpatch.pl, line length of 123 exceeds 100 columns, so fix it. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: lapbether: fix the alignment issue

2021-06-09T21:02:58+00:00

Alignment should match open parenthesis. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: lapbether: replace comparison to NULL with "lapbeth_get_x25_dev"

2021-06-09T21:02:58+00:00

According to the chackpatch.pl, comparison to NULL could be written "lapbeth_get_x25_dev". Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: lapbether: fix the comments style issue

2021-06-09T21:02:58+00:00

Networking block comments don't use an empty /* line, use /* Comment... Block comments use * on subsequent lines. Block comments use a trailing */ on a separate line. This patch fixes the comments style issues. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: lapbether: remove unnecessary out of memory message

2021-06-09T21:02:58+00:00

This patch removes unnecessary out of memory message, to fix the following checkpatch.pl warning: "WARNING: Possible unnecessary 'out of memory' message" Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: lapbether: remove trailing whitespaces

2021-06-09T21:02:58+00:00

This patch removes trailing whitespaces. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: lapbether: move out assignment in if condition

2021-06-09T21:02:58+00:00

Should not use assignment in if condition. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang Signed-off-by: David S. Miller

net: lapbether: add blank line after declarations

2021-06-09T21:02:58+00:00

This patch fixes the checkpatch error about missing a blank line after declarations. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: lapbether: remove redundant blank line

2021-06-09T21:02:58+00:00

This patch the redundant blank line. Signed-off-by: Peng Li Signed-off-by: David S. Miller

net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-04-05T18:42:12+00:00

X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver the received packets to layer 3, because "netif_rx" will put the packets into per-CPU queues before they are delivered to layer 3. If there are multiple CPUs, the order of the packets may not be preserved. The per-CPU queues may also drop packets if there are too many. Therefore, we should not call "netif_rx" to let it queue the packets. Instead, we should use our own queue that won't reorder or drop packets. This patch changes all X.25 drivers to use their own queues instead of calling "netif_rx". The patch also documents this requirement in the "x25-iface" documentation. Cc: Martin Schiller Signed-off-by: Xie He Signed-off-by: David S. Miller