BMC/Intel-BMC/linux.git/drivers/net/can/spi, branch dev-5.4

can: mcp251x: mcp251x_restart_work_handler(): Fix potential force_quit race condition

2019-11-05T11:44:22+00:00

In mcp251x_restart_work_handler() the variable to stop the interrupt handler (priv->force_quit) is reset after the chip is restarted and thus a interrupt might occur. This patch fixes the potential race condition by resetting force_quit before enabling interrupts. Signed-off-by: Timo Schlüßler Signed-off-by: Marc Kleine-Budde

can: mcp251x: Call wrapper instead of regulator_disable()

2019-09-03T08:23:57+00:00

There is no need to check for regulator presence in the ->suspend() since a wrapper does it for us. Due to this we may unconditionally set AFTER_SUSPEND_POWER flag. Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: Make use of device property API

2019-09-03T08:23:57+00:00

Make use of device property API in this driver so that both OF based system and ACPI based system can use this driver. Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: Use devm_clk_get_optional() to get the input clock

2019-09-03T08:23:57+00:00

Simplify the code which fetches the input clock by using devm_clk_get_optional(). This comes with a small functional change: previously all errors were ignored when platform data is present. Now all errors are treated as errors. If no input clock is present devm_clk_get_optional() will return NULL instead of an error which matches the behavior of the old code. Signed-off-by: Andy Shevchenko Signed-off-by: Marc Kleine-Budde

can: mcp251x: remove deprecated board file setup example

2019-09-03T08:23:57+00:00

In the pre device-tree ARM aera there were board files that configured the system (instead of a device tree). A "struct spi_board_info" was used to describe the SPI bus. As new systems should be described via device trees, this patch removes the board setup example from the driver. The "struct mcp251x_platform_data" cannot be removed completely, as there are still some in-tree users of this file. Signed-off-by: Marc Kleine-Budde

can: Delete unnecessary checks before the macro call “dev_kfree_skb”

2019-08-22T23:22:03+00:00

The dev_kfree_skb() function performs also input parameter validation. Thus the test around the shown calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Sean Nyekjaer Signed-off-by: David S. Miller

can: mcp251x: remove custom DMA mapped buffer

2019-08-20T11:41:26+00:00

There is no need to duplicate what SPI core already does, i.e. mapping buffers for DMA capable transfers. This patch removes all related pices of code. Tested-by: Sean Nyekjaer Signed-off-by: Marc Kleine-Budde

can: mcp251x: Use DT-supplied interrupt flags

2019-08-20T11:41:26+00:00

The MCP2515 datasheet clearly describes a level-triggered interrupt pin. Therefore the receiving interrupt controller must also be configured for level-triggered operation otherwise there is a danger of a missed interrupt condition blocking all subsequent interrupts. The ONESHOT flag ensures that the interrupt is masked until the threaded interrupt handler exits. Rather than change the flags globally (they must have worked for at least one user), keep the old behavior for for non DT devices. DT based devices specify the flags in their corresonding DT node. See: https://github.com/raspberrypi/linux/issues/2175 https://github.com/raspberrypi/linux/issues/2263 Signed-off-by: Phil Elwell Tested-by: Sean Nyekjaer Signed-off-by: Marc Kleine-Budde

can: mcp251x: Use dev_name() during request_threaded_irq()

2019-08-20T11:41:26+00:00

Passing driver name as name during request_threaded_irq() results in all CAN IRQs have same name. This does not help much to easily identify which IRQ belongs to which CAN instance. Therefore pass dev_name() during request_threaded_irq() so that better identifiable name is listed for CAN devices in cat /proc/interrupts output. Output of cat /proc/interrupts Before this patch: 253: 2 gpio-mxc 13 Edge mcp251x 259: 2 gpio-mxc 19 Edge mcp251x After this patch: 253: 2 gpio-mxc 13 Edge spi1.1 259: 2 gpio-mxc 19 Edge spi1.2 Signed-off-by: Alexander Shiyan Tested-by: Sean Nyekjaer Signed-off-by: Marc Kleine-Budde

can: mcp251x: mcp251x_hw_reset(): allow more time after a reset

2019-08-20T11:41:26+00:00

Some boards take longer than 5ms to power up after a reset, so allow some retries attempts before giving up. Fixes: ff06d611a31c ("can: mcp251x: Improve mcp251x_hw_reset()") Cc: linux-stable Tested-by: Sean Nyekjaer Signed-off-by: Marc Kleine-Budde