BMC/Intel-BMC/linux.git/drivers/md/dm-integrity.c, branch dev-5.7

dm integrity: fix integrity recalculation that is improperly skipped

2020-07-29T08:20:00+00:00

commit 5df96f2b9f58a5d2dc1f30fe7de75e197f2c25f2 upstream. Commit adc0daad366b62ca1bce3e2958a40b0b71a8b8b3 ("dm: report suspended device during destroy") broke integrity recalculation. The problem is dm_suspended() returns true not only during suspend, but also during resume. So this race condition could occur: 1. dm_integrity_resume calls queue_work(ic->recalc_wq, &ic->recalc_work) 2. integrity_recalc (&ic->recalc_work) preempts the current thread 3. integrity_recalc calls if (unlikely(dm_suspended(ic->ti))) goto unlock_ret; 4. integrity_recalc exits and no recalculating is done. To fix this race condition, add a function dm_post_suspending that is only true during the postsuspend phase and use it instead of dm_suspended(). Signed-off-by: Mikulas Patocka Fixes: adc0daad366b ("dm: report suspended device during destroy") Cc: stable vger kernel org # v4.18+ Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman

dm integrity: fix logic bug in integrity tag testing

2020-04-03T17:07:41+00:00

If all the bytes are equal to DISCARD_FILLER, we want to accept the buffer. If any of the bytes are different, we must do thorough tag-by-tag checking. The condition was inverted. Fixes: 84597a44a9d8 ("dm integrity: add optional discard support") Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: fix ppc64le warning

2020-04-03T14:44:24+00:00

Otherwise: In file included from drivers/md/dm-integrity.c:13: drivers/md/dm-integrity.c: In function 'dm_integrity_status': drivers/md/dm-integrity.c:3061:10: error: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'long int' [-Werror=format=] DMEMIT("%llu %llu", ^~~~~~~~~~~ atomic64_read(&ic->number_of_mismatches), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./include/linux/device-mapper.h:550:46: note: in definition of macro 'DMEMIT' 0 : scnprintf(result + sz, maxlen - sz, x)) ^ cc1: all warnings being treated as errors Fixes: 7649194a1636ab5 ("dm integrity: remove sector type casts") Signed-off-by: Mike Snitzer

dm integrity: improve discard in journal mode

2020-03-24T17:09:49+00:00

When we discard something that is present in the journal, we flush the journal first, so that discarded blocks are not overwritten by the journal content. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: add optional discard support

2020-03-24T17:05:25+00:00

Add an argument "allow_discards" that enables discard processing on dm-integrity device. Discards are only allowed to devices using internal hash. When a block is discarded the integrity tag is filled with DISCARD_FILLER (0xf6) bytes. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: allow resize of the integrity device

2020-03-24T16:52:53+00:00

If the size of the underlying device changes, change the size of the integrity device too. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: factor out get_provided_data_sectors()

2020-03-24T16:46:35+00:00

Move code to a new function get_provided_data_sectors(). Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: don't replay journal data past the end of the device

2020-03-24T16:43:21+00:00

Following commits will make it possible to shrink or extend the device. If the device was shrunk, we don't want to replay journal data pointing past the end of the device. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: remove sector type casts

2020-03-24T16:40:18+00:00

Since the commit 72deb455b5ec619ff043c30bc90025aa3de3cdda ("block: remove CONFIG_LBDAF") sector_t is always defined as unsigned long long. Delete the needless type casts in printk and avoids some warnings if DEBUG_PRINT is defined. Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer

dm integrity: fix a crash with unusually large tag size

2020-03-24T16:34:45+00:00

If the user specifies tag size larger than HASH_MAX_DIGESTSIZE, there's a crash in integrity_metadata(). Cc: stable@vger.kernel.org Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer