BMC/Intel-BMC/linux.git/drivers/isdn/capi, branch dev

isdn/capi: Use setup_timer

2015-06-01T04:36:37+00:00

Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, e3, e4, a, b; @@ -init_timer(&e1); +setup_timer(&e1, a, b); ... when != a = e2 when != b = e3 -e1.data = b; ... when != a = e4 -e1.function = a; Signed-off-by: Vaishali Thakkar Signed-off-by: David S. Miller

isdn/capi: correct argument types of command_2_index

2014-12-10T20:06:10+00:00

Utility function command_2_index is always called with arguments of type u8. Adapt its declaration accordingly. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: don't return NULL from capi_cmd2str()

2014-10-14T19:05:35+00:00

capi_cmd2str() is used in many places to build log messages. None of them is prepared to handle NULL as a result. Change the function to return printable string "INVALID_COMMAND" instead. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: handle CAPI 2.0 message parser failures

2014-10-14T19:05:35+00:00

Have callers of capi_cmsg2message and capi_message2cmsg handle non-zero return values indicating failure. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: prevent NULL pointer dereference on invalid CAPI command

2014-10-14T19:05:34+00:00

An invalid CAPI 2.0 command/subcommand combination may retrieve a NULL pointer from the cpars[] array which will later be dereferenced by the parser routines. Fix by adding NULL pointer checks in strategic places. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: refactor command/subcommand table accesses

2014-10-14T19:05:34+00:00

Encapsulate accesses to the CAPI 2.0 command/subcommand name and parameter tables in a single place in preparation for redesign. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: prevent index overrun from command_2_index()

2014-10-14T19:05:34+00:00

The result of the function command_2_index() is used to index two arrays mnames[] and cpars[] with max. index 0x4e but in its current form that function can produce results up to 3*(0x9+0x9)+0x7f = 0xb5. Fix by clamping all result values potentially overrunning the arrays to zero which is already handled as an invalid value. Re-spotted with Coverity. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: correct capi20_manufacturer argument type mismatch

2014-10-14T19:05:34+00:00

Function capi20_manufacturer() is declared with unsigned int cmd argument but called with unsigned long. Fix by correcting the function prototype since the actual argument is part of the user visible API. Spotted with Coverity. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

isdn/capi: drop two dead if branches

2014-10-06T01:17:51+00:00

The last branch in command_2_index() cannot be reached since c==0xff is already caught by the first "if". The empty second branch makes no difference since no other branch will be taken for c<0x0f. Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller

CAPI: use correct structure type name in sizeof

2014-07-31T02:13:40+00:00

Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used can be found in message 0 of this patch series. Signed-off-by: Julia Lawall Signed-off-by: David S. Miller