BMC/Intel-BMC/linux.git/drivers/i2c, branch dev-4.3

i2c: aspeed: Don't rename added devices

2016-02-22T05:21:47+00:00

Changing the name of a device with dev_set_name after device_add is not allowed. However, of_create_device takes a bus_id parameter that specifies the name of the platform device being added. This does mean the bus property has to be retrieved multiple times. Creation is skiped if there is trouble retrieving or formatting the name. The documentation for kobject_set_name (non-vargs) says: * This sets the name of the kobject. If you have already added the * kobject to the system, you must call kobject_rename() in order to * change the name of the kobject. As the kernel doc for device_rename says: * Make up a "real" name in the driver before you register anything, or add * some other attributes for userspace to find the device, or use udev to add * symlinks -- but never rename kernel devices later, it's a complete mess. We * don't even want to get into that and try to implement the missing pieces in * the core. We really have other pieces to fix in the driver core mess. :) before: 1e78a000.i2c/1e78a1c0.i2c-bus/i2c-6/i2c-dev/i2c-6 1e78a000.i2c/1e78a180.i2c-bus/i2c-5/i2c-dev/i2c-5 1e78a000.i2c/1e78a140.i2c-bus/i2c-4/i2c-dev/i2c-4 1e78a000.i2c/1e78a100.i2c-bus/i2c-3/i2c-dev/i2c-3 1e78a000.i2c/1e78a100.i2c-bus/i2c-3/3-0050 1e78a000.i2c/1e78a0c0.i2c-bus/i2c-2/i2c-dev/i2c-2 1e78a000.i2c/1e78a0c0.i2c-bus/i2c-2/2-004c/hwmon/hwmon0 1e78a000.i2c/1e78a080.i2c-bus/i2c-1/i2c-dev/i2c-1 1e78a000.i2c/1e78a040.i2c-bus/i2c-0/i2c-dev/i2c-0 1e78a000.i2c/1e78a040.i2c-bus/i2c-0/0-0050 1e78a000.i2c/1e78a040.i2c-bus/i2c-0/0-0068/rtc/rtc0 1e78a000.i2c/1e78a340.i2c-bus/i2c-8/i2c-dev/i2c-8 after: 1e78a000.i2c/i2c-0/i2c-0/i2c-dev/i2c-0 1e78a000.i2c/i2c-0/i2c-0/0-0050 1e78a000.i2c/i2c-0/i2c-0/0-0068/rtc/rtc0 1e78a000.i2c/i2c-1/i2c-1/i2c-dev/i2c-1 1e78a000.i2c/i2c-2/i2c-2/i2c-dev/i2c-2 1e78a000.i2c/i2c-2/i2c-2/2-004c/hwmon/hwmon0 1e78a000.i2c/i2c-3/i2c-3/i2c-dev/i2c-3 1e78a000.i2c/i2c-3/i2c-3/3-0050 1e78a000.i2c/i2c-4/i2c-4/i2c-dev/i2c-4 1e78a000.i2c/i2c-5/i2c-5/i2c-dev/i2c-5 1e78a000.i2c/i2c-6/i2c-6/i2c-dev/i2c-6 1e78a000.i2c/i2c-7/i2c-7/i2c-dev/i2c-7 1e620000.fmc 1e78e000.serial 1e620000.fmc:flash@0 1e78f000.serial 1e630000.spi ahb 1e630000.spi:flash ahb:apb 1e660000.ethernet alarmtimer 1e6c0080.interrupt-controller i2c-0 1e6e2000.syscon i2c-1 1e720000.sram i2c-2 1e780000.gpio i2c-3 1e782000.timer i2c-4 1e783000.serial i2c-5 1e784000.serial i2c-6 1e785000.wdt i2c-7 1e787000.vuart i2c-8 1e789140.ibt leds 1e78a000.i2c serial8250 1e78d000.serial Signed-off-by: Milton Miller Signed-off-by: Joel Stanley

Merge tag 'v4.3.6' into dev-4.3

2016-02-22T05:13:27+00:00

This is the 4.3.6 stable release Signed-off-by: Joel Stanley

i2c: rcar: disable runtime PM correctly in slave mode

2016-02-19T22:28:29+00:00

commit b4cd08aa1f53c831e67dc5c6bc9f9acff27abcba upstream. When we also are I2C slave, we need to disable runtime PM because the address detection mechanism needs to be active all the time. However, we can reenable runtime PM once the slave instance was unregistered. So, use pm_runtime_get_sync/put to achieve this, since it has proper refcounting. pm_runtime_allow/forbid is like a global knob controllable from userspace which is unsuitable here. Signed-off-by: Wolfram Sang Signed-off-by: Wolfram Sang Signed-off-by: Greg Kroah-Hartman

i2c: rk3x: populate correct variable for sda_falling_time

2016-02-19T22:28:29+00:00

commit 9abd29e7c13de24ce73213a425d9574b35ac0c6a upstream. Signed-off-by: Wolfram Sang Reviewed-by: Douglas Anderson Signed-off-by: Greg Kroah-Hartman

i2c: mv64xxx: The n clockdiv factor is 0 based on sunxi SoCs

2016-02-19T22:28:29+00:00

commit bba61f50f76574ca5b84b310925be7c2e8e64275 upstream. According to the datasheets the n factor for dividing the tclk is 2 to the power n on Allwinner SoCs, not 2 to the power n + 1 as it is on other mv64xxx implementations. I've contacted Allwinner about this and they have confirmed that the datasheet is correct. This commit fixes the clk-divider calculations for Allwinner SoCs accordingly. Signed-off-by: Hans de Goede Acked-by: Maxime Ripard Tested-by: Olliver Schinagl Signed-off-by: Wolfram Sang Signed-off-by: Greg Kroah-Hartman

i2c: fix wakeup irq parsing

2016-02-19T22:28:28+00:00

commit c18fba23061f16dde128e10d4869ba4e88e0e81a upstream. This patch fixes obvious copy-past error in wake up irq parsing code which leads to the fact that dev_pm_set_wake_irq() will be called with wrong IRQ number when "wakeup" IRQ is not defined in DT. Fixes: 3fffd1283927 ("i2c: allow specifying separate wakeup interrupt in device tree") Signed-off-by: Grygorii Strashko Acked-by: Dmitry Torokhov Signed-off-by: Wolfram Sang Signed-off-by: Greg Kroah-Hartman

i2c: at91: manage unexpected RXRDY flag when starting a transfer

2016-02-19T22:28:28+00:00

commit a9bed6b10bd117a300cceb9062003f7a2761ef99 upstream. In some cases, we could start a new i2c transfer with the RXRDY flag set. It is not a clean state and it leads to print annoying error messages even if there no real issue. The cause is only having garbage data in the Receive Holding Register because of a weird behavior of the RXRDY flag. Reported-by: Peter Rosin Signed-off-by: Ludovic Desroches Tested-by: Peter Rosin Signed-off-by: Wolfram Sang Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Signed-off-by: Greg Kroah-Hartman

i2c: at91: fix write transfers by clearing pending interrupt first

2016-02-19T22:28:28+00:00

commit 6f6ddbb09d2a5baded0e23add3ad2d9e9417ab30 upstream. In some cases a NACK interrupt may be pending in the Status Register (SR) as a result of a previous transfer. However at91_do_twi_transfer() did not read the SR to clear pending interruptions before starting a new transfer. Hence a NACK interrupt rose as soon as it was enabled again at the I2C controller level, resulting in a wrong sequence of operations and strange patterns of behaviour on the I2C bus, such as a clock stretch followed by a restart of the transfer. This first issue occurred with both DMA and PIO write transfers. Also when a NACK error was detected during a PIO write transfer, the interrupt handler used to wrongly start a new transfer by writing into the Transmit Holding Register (THR). Then the I2C slave was likely to reply with a second NACK. This second issue is fixed in atmel_twi_interrupt() by handling the TXRDY status bit only if both the TXCOMP and NACK status bits are cleared. Tested with a at24 eeprom on sama5d36ek board running a linux-4.1-at91 kernel image. Adapted to linux-next. Reported-by: Peter Rosin Signed-off-by: Cyrille Pitchen Signed-off-by: Ludovic Desroches Tested-by: Peter Rosin Signed-off-by: Wolfram Sang Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Signed-off-by: Greg Kroah-Hartman

i2c/aspeed: Set pdev name corresponding to bus

2016-02-10T06:09:15+00:00

Our device name is derived from the address the peripheral sits at in mmio space; this is not useful for users. Instead name it after the i2c bus. Milton explains why this is important for IRQ debugging: The aspeed i2c controller has an irq per bus and this has been exposed as an irq domain. However, each irq is requested the same device name, leaving one to guess which irq in /proc/interrupts corresponds to which device. While the controller irq number is unique and happens to match, it is not obvious that there is no offset. The driver registers the bus with the numbered bus api, so the global bus number is known an we can predict it before registering. The information that this is from an ast-i2c bus is in the irq controller name or could be found from the matching i2c bus device in sysfs. Excerpt of /proc/interrupts before this patch: 220: 1094 ast-i2c 0 Edge ast-i2c-bus 221: 0 ast-i2c 1 Edge ast-i2c-bus 222: 9438 ast-i2c 2 Edge ast-i2c-bus 223: 26480 ast-i2c 3 Edge ast-i2c-bus New excerpt from /proc/interrupts: 220: 1094 ast-i2c 0 Edge i2c-0 221: 0 ast-i2c 1 Edge i2c-1 222: 9438 ast-i2c 2 Edge i2c-2 223: 26480 ast-i2c 3 Edge i2c-3 224: 0 ast-i2c 4 Edge i2c-4 New example proc/irq/ directory: /proc/irq/222: i2c-2 spurious Signed-off-by: Joel Stanley

i2c/aspeed: Simplify resource acquisition

2016-02-10T06:07:45+00:00

Signed-off-by: Joel Stanley