BMC/Intel-BMC/linux.git/drivers/hwmon/occ, branch dev-5.2

hwmon (occ): Fix division by zero issue

2019-07-10T07:30:16+00:00

The code in occ_get_powr_avg() invokes div64_u64() without checking the divisor. In case the divisor is zero, kernel gets an "Division by zero in kernel" error. Check the divisor and make it return 0 if the divisor is 0. OpenBMC-Staging-Count: 1 Signed-off-by: Lei YU Reviewed-by: Eddie James Signed-off-by: Joel Stanley

hwmon (occ): Add temp sensor value check

2019-07-10T07:30:15+00:00

The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources for P8 reveals that OCC may send a special value 0xFFFF to indicate that a sensor read timeout has occurred, see https://github.com/open-power/occ/blob/master_p8/src/occ/cmdh/cmdh_fsp_cmds.c#L395 That situation wasn't handled in the driver. This patch adds invalid temp value check for the sensor data format 1 and handles it the same way as it is done for the format 2, where EREMOTEIO is reported for this case. OpenBMC-Staging-Count: 3 Signed-off-by: Alexander Soldatov Signed-off-by: Alexander Amelkin Reviewed-by: Alexander Amelkin Cc: Edward A. James Cc: Joel Stanley Reviewed-by: Eddie James Signed-off-by: Joel Stanley

OCC: FSI and hwmon: Add sequence numbering

2019-07-10T07:09:12+00:00

Sequence numbering of the commands submitted to the OCC is required by the OCC interface specification. Add sequence numbering and check for the correct sequence number on the response. Signed-off-by: Eddie James Acked-by: Guenter Roeck Reviewed-by: Lei YU Signed-off-by: Joel Stanley (cherry picked from commit afd26118f0dcf29db031a213f6f95c46ff3bdcbe) Signed-off-by: Joel Stanley

treewide: Add SPDX license identifier - Makefile/Kconfig

2019-05-21T08:50:46+00:00

Add SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any form These files fall under the project license, GPL v2 only. The resulting SPDX license identifier is: GPL-2.0-only Signed-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman

hwmon: (occ) Add more details to Kconfig help text

2019-04-16T22:15:52+00:00

The help text needs to spell out how the driver runs on a BMC, as it previously seemed to indicate it ran on a POWER processor. Signed-off-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Prevent sysfs error attribute from returning error

2019-04-16T22:13:54+00:00

The error sysfs attribute returns the stored error state of the OCC and doesn't depend on the OCC poll response. Therefore, split the error attribute into it's own function to avoid failing out of the function if the poll response fails. Signed-off-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Store error condition for rate-limited polls

2019-04-16T22:12:13+00:00

The OCC driver limits the rate of sending poll commands to the OCC. If a user reads a hwmon entry after a poll response resulted in an error and is rate-limited, the error is invisible to the user. Fix this by storing the last error and returning that in the rate-limited case. Signed-off-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: OCC drivers are ARM-only

2019-04-16T00:19:53+00:00

These drivers are for a BMC inside PowerPC servers. The BMC runs on ARM hardware, so only propose the drivers on this architecture, unless build-testing. Signed-off-by: Jean Delvare Cc: Eddie James Cc: Guenter Roeck Reviewed-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Move common code to a separate module

2019-04-16T00:19:53+00:00

Instead of duplicating the common code into the 2 (binary) drivers, move the common code to a separate module. This is cleaner. Signed-off-by: Jean Delvare Cc: Eddie James Cc: Guenter Roeck Reviewed-by: Eddie James Tested-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Fix extended status bits

2019-04-16T00:19:23+00:00

The occ's extended status is checked and shown as sysfs attributes. But the code was incorrectly checking the "status" bits. Fix it by checking the "ext_status" bits. Cc: stable@vger.kernel.org Fixes: df04ced684d4 ("hwmon (occ): Add sysfs attributes for additional OCC data") Signed-off-by: Lei YU Reviewed-by: Eddie James Signed-off-by: Guenter Roeck