BMC/Intel-BMC/linux.git/drivers/hwmon/occ, branch dev-4.10

hwmon (occ): Fix integer overflow in multiplication

2018-01-16T17:54:30+00:00

Power values were overflowing INT_MAX when being converted to microwatts, even though the storage was sufficiently large (unsigned 64 bit). Change literals to unsigned long long. Also change tmep storage to u32 to avoid overflows at 65000 millidegrees. OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Signed-off-by: Joel Stanley

drivers (hwmon): occ: Fix memory allocation for extended sensors

2017-10-26T21:16:46+00:00

If extended sensors are present, the driver is doing bad memory access since we weren't allocating enough memory for the extended sensors. Fix this with proper allocation for extended sensor attributes. OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery

drivers: hwmon: occ: Add sysfs_notify to throttling attributes

2017-10-17T11:04:14+00:00

Need to alert user space when we change throttling state. OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery

drivers: hwmon: occ: Add occs_present attribute

2017-10-17T11:02:57+00:00

Remove the error on detecting occs_present mismatch. Add a new sysfs entry for occs_present field. Add sysfs_notify for this field, if it changes. Two reasons for this change: 1) Userspace app was having trouble handling this error code, since if you bind the master OCC device first, you'll immediately get an error that we haven't bound the same number of OCCs as the OCC reports are available. 2) This error checking for "number of OCC devices bound" isn't designed well anyway, and makes more sense in userspace. The original intent was to implement all of the OCC requirements in the driver, but we have an application running on top that can pick up the slack, as it were. OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery

drivers: hwmon: occ: Cancel occ operations in remove()

2017-10-10T04:59:30+00:00

Prevent hanging forever waiting for OCC ops to complete. OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Signed-off-by: Joel Stanley

hwmon: (occ) Remove repeated ops for OCC command in progress

2017-10-10T04:59:27+00:00

This is now handled in the occ driver. OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Reviewed-by: Andrew Jeffery Signed-off-by: Joel Stanley

Revert "drivers/hwmon/occ: Add temperature fault attribute and VRM temp alarm"

2017-10-05T03:48:36+00:00

This reverts commit e55423ee10a5057338d24383c00e813436a126ea. Apologies for pushing this up so early... Userspace applications aren't ready for this change. The hwmon polling application cannot accept EGAIN yet, and we can't be returning apparent errors if the sensor is temporarily unavailable. Brad Bishop wrote: > userspace retries for a configurable period on eio, etimedout, > ebadmsg, eagain, and exnio. It also exits cleanly on enoent. > > If any of these errnos don’t go away after the configured number of retry > attempts, an error is logged. Any other errnos and an error is logged > immediately. If this list needs improvement I’d love to hear about it. > > ebadmsg and enxio are observed when i2c devices are unplugged with transfers > in various stages of flight. They occur just before the driver is unbound > after the presence gpio toggle on these devices is noticed and processed > (killing the hwmon userspace daemon cleanly). > > eio, etimedout seem to be bus type errors that appear somewhat infrequently, > but occur nevertheless. > > we all know what eagain means... > > It isn’t so much that the hwmon userspace doesn’t support this change, > its just the resulting behavior difference at the other end of the > hwmon abi <-> dbus api translation is not optimal, right now. > > 1 - Without this change, the hwmon userspace reads a value of 0 out of > the sysfs attribute and happily reports that as the temp at the DBus level. > > With this change, the hwmon userspace would read the attribute, get an > error and retry for a bit. After a number of retries, the error is > logged and the sensor is marked faulted at a dbus level. > > The issue is the consumer of the sensor at the dbus level. Today, the > dbus consumer happens to translate the sensor value of zero into the > desired behavior. If we submit this change the sensor will be put > into faulted state and the consuming application doesn’t have support > for that yet. > > We have open issues to enhance the application to support faulted sensors, > its just not implemented yet. OpenBMC-Staging-Count: 1 Signed-off-by: Eddie James Signed-off-by: Joel Stanley

drivers/hwmon/occ: Add temperature fault attribute and VRM temp alarm

2017-09-21T06:04:01+00:00

VRM temp doesn't return temperature, only alarm bit. Add fault attribute, triggered when the temp sensor returns the 0xFF code. OpenBMC-Staging-Count: 1 Signed-off-by: Eddie James Signed-off-by: Joel Stanley

hwmon: (occ): Return power readings in micro-Watts

2017-08-23T07:05:16+00:00

hwmon expects -6 exponent. Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery

hwmon: (occ) Add error thresholding back in

2017-08-10T03:44:20+00:00

Threshold communication and message errors to the OCC, such that errors are only valid after two have been observed in a row. This thresholding is required by the OCC specification. An old P8 OCC spec is available here: https://github.com/open-power/docs/blob/master/occ/OCC_OpenPwr_FW_Interfaces.pdf OpenBMC-Staging-Count: 1 Signed-off-by: Edward A. James Signed-off-by: Joel Stanley