BMC/Intel-BMC/linux.git/drivers/hwmon/occ/common.c, branch dev-5.2

hwmon (occ): Fix division by zero issue

2019-07-10T07:30:16+00:00

The code in occ_get_powr_avg() invokes div64_u64() without checking the divisor. In case the divisor is zero, kernel gets an "Division by zero in kernel" error. Check the divisor and make it return 0 if the divisor is 0. OpenBMC-Staging-Count: 1 Signed-off-by: Lei YU Reviewed-by: Eddie James Signed-off-by: Joel Stanley

hwmon (occ): Add temp sensor value check

2019-07-10T07:30:15+00:00

The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources for P8 reveals that OCC may send a special value 0xFFFF to indicate that a sensor read timeout has occurred, see https://github.com/open-power/occ/blob/master_p8/src/occ/cmdh/cmdh_fsp_cmds.c#L395 That situation wasn't handled in the driver. This patch adds invalid temp value check for the sensor data format 1 and handles it the same way as it is done for the format 2, where EREMOTEIO is reported for this case. OpenBMC-Staging-Count: 3 Signed-off-by: Alexander Soldatov Signed-off-by: Alexander Amelkin Reviewed-by: Alexander Amelkin Cc: Edward A. James Cc: Joel Stanley Reviewed-by: Eddie James Signed-off-by: Joel Stanley

OCC: FSI and hwmon: Add sequence numbering

2019-07-10T07:09:12+00:00

Sequence numbering of the commands submitted to the OCC is required by the OCC interface specification. Add sequence numbering and check for the correct sequence number on the response. Signed-off-by: Eddie James Acked-by: Guenter Roeck Reviewed-by: Lei YU Signed-off-by: Joel Stanley (cherry picked from commit afd26118f0dcf29db031a213f6f95c46ff3bdcbe) Signed-off-by: Joel Stanley

hwmon: (occ) Store error condition for rate-limited polls

2019-04-16T22:12:13+00:00

The OCC driver limits the rate of sending poll commands to the OCC. If a user reads a hwmon entry after a poll response resulted in an error and is rate-limited, the error is invisible to the user. Fix this by storing the last error and returning that in the rate-limited case. Signed-off-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Move common code to a separate module

2019-04-16T00:19:53+00:00

Instead of duplicating the common code into the 2 (binary) drivers, move the common code to a separate module. This is cleaner. Signed-off-by: Jean Delvare Cc: Eddie James Cc: Guenter Roeck Reviewed-by: Eddie James Tested-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Fix power sensor indexing

2019-03-29T16:51:44+00:00

In the case of power sensor version 0xA0, the sensor indexing overlapped with the "caps" power sensors, resulting in probe failure and kernel warnings. Fix this by specifying the next index for each power sensor version. Fixes: 54076cb3b5ff ("hwmon (occ): Add sensor attributes and register ...") Cc: stable@vger.kernel.org Signed-off-by: Eddie James Tested-by: Joel Stanley Signed-off-by: Guenter Roeck

hwmon: (occ) Fix license headers

2019-02-18T22:23:29+00:00

Files have inconsistent license information. Signed-off-by: Eddie James Signed-off-by: Guenter Roeck

hwmon: (occ) Fix potential integer overflow

2019-01-08T05:03:59+00:00

Cast get_unaligned_be32(...) to u64 in order to give the compiler complete information about the proper arithmetic to use and avoid a potential integer overflow. Notice that such function call is used in contexts that expect expressions of type u64 (64 bits, unsigned); and the following expressions are currently being evaluated using 32-bit arithmetic: val = get_unaligned_be32(&power->update_tag) * occ->powr_sample_time_us; val = get_unaligned_be32(&power->vdn.update_tag) * occ->powr_sample_time_us; Addresses-Coverity-ID: 1442357 ("Unintentional integer overflow") Addresses-Coverity-ID: 1442476 ("Unintentional integer overflow") Addresses-Coverity-ID: 1442508 ("Unintentional integer overflow") Fixes: ff692d80b2e2 ("hwmon (occ): Add sensor types and versions") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Reviewed-by: Eddie James Signed-off-by: Guenter Roeck

hwmon (occ): Add sysfs attributes for additional OCC data

2018-12-16T23:13:10+00:00

The OCC provides a variety of additional information about the state of the host processor, such as throttling, error conditions, and the number of OCCs detected in the system. This information is essential to service processor applications such as fan control and host management. Therefore, export this data in the form of sysfs attributes attached to the platform device (to which the hwmon device is also attached). Signed-off-by: Eddie James Signed-off-by: Guenter Roeck

hwmon (occ): Add sensor attributes and register hwmon device

2018-12-16T23:13:09+00:00

Setup the sensor attributes for every OCC sensor found by the first poll response. Register the attributes with hwmon. Signed-off-by: Eddie James Signed-off-by: Guenter Roeck