BMC/Intel-BMC/linux.git/drivers/fsi, branch dev-5.1

fsi/core: Fix error paths on CFAM init

2019-07-02T05:47:55+00:00

Change d1dcd67825 re-worked the struct fsi_slave initialisation in fsi_slave_init, but introduced a few inconsitencies: the slave->dev is now registered through cdev_device_add, but we may kfree() the device out from underneath the cdev registration. We may also leave an IDA allocated. This change fixes the error paths, so that we kfree() only before the device is registered with the core code. We also move the smode write to before we start creating proper devices, as it's the most likely to fail. We also remove the IDA-allocated minor on error, and properly clean up the of_node. OpenBMC-Staging-Count: 1 Fixes: d1dcd6782576 ("fsi: Add cfam char devices") Reported-by: Lei YU Signed-off-by: Jeremy Kerr Tested-by: John Wang Signed-off-by: Joel Stanley

OCC: FSI and hwmon: Add sequence numbering

2019-07-02T05:04:17+00:00

Sequence numbering of the commands submitted to the OCC is required by the OCC interface specification. Add sequence numbering and check for the correct sequence number on the response. OpenBMC-Staging-Count: 1 Signed-off-by: Eddie James Reviewed-by: Lei YU Signed-off-by: Joel Stanley

fsi: sbefifo: Don't fail operations when in SBE IPL state

2019-06-14T06:18:50+00:00

SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state. OpenBMC-Staging-Count: 1 Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO Signed-off-by: Eddie James Signed-off-by: Joel Stanley

fsi: Add On-Chip Controller (OCC) driver

2018-12-03T00:25:28+00:00

The OCC is a device embedded on a POWER processor that collects and aggregates sensor data from the processor and system. The OCC can provide the raw sensor data as well as perform thermal and power management on the system. This driver provides an atomic communications channel between a service processor (e.g. a BMC) and the OCC. The driver is dependent on the FSI SBEFIFO driver to get hardware access through the SBE to the OCC SRAM. Commands are issued to the SBE to send or fetch data to the SRAM. Signed-off-by: Eddie James Signed-off-by: Andrew Jeffery Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Joel Stanley Signed-off-by: Guenter Roeck

fsi: fsi-scom.c: Remove duplicate header

2018-11-25T23:13:04+00:00

Remove linux/cdev.h which is included more than once Signed-off-by: Brajeswar Ghosh Signed-off-by: Benjamin Herrenschmidt

fsi: master-ast-cf: select GENERIC_ALLOCATOR

2018-11-25T23:11:43+00:00

In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver fails to link: ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "gen_pool_free" [drivers/fsi/fsi-master-ast-cf.ko] undefined! Select the dependency as all other users do. Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire") Signed-off-by: Arnd Bergmann Signed-off-by: Benjamin Herrenschmidt

iov_iter: Separate type from direction and use accessor functions

2018-10-23T23:41:07+00:00

In the iov_iter struct, separate the iterator type from the iterator direction and use accessor functions to access them in most places. Convert a bunch of places to use switch-statements to access them rather then chains of bitwise-AND statements. This makes it easier to add further iterator types. Also, this can be more efficient as to implement a switch of small contiguous integers, the compiler can use ~50% fewer compare instructions than it has to use bitwise-and instructions. Further, cease passing the iterator type into the iterator setup function. The iterator function can set that itself. Only the direction is required. Signed-off-by: David Howells

fsi: sbefifo: Bump max command length

2018-08-08T05:44:47+00:00

Otherwise cronus putmem fails istep and BML fails to upload skiboot To do that, we still use our one-page command buffer for small commands for speed, and for anything bigger, with a limit of 1MB plus a page, we vmalloc a temporary buffer. The limit was chosen because Cronus will break up any data transfer into 1M chunks (the extra page is for the command header). Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Andrew Jeffery

fsi: scom: Fix NULL dereference

2018-08-06T02:27:04+00:00

The chardev conversion forgot to copy the fsi_dev, silly mistake, compounded by a testing mistake on my side, this specific driver wasn't being tested properly. Fixes: d8f4587655f9 "fsi: scom: Convert to use the new chardev" Signed-off-by: Benjamin Herrenschmidt

fsi: Prevent multiple concurrent rescans

2018-07-26T23:58:12+00:00

The bus scanning process isn't terribly good at parallel attempts at rescanning the same bus. Let's have a per-master mutex protecting the scanning process. Signed-off-by: Benjamin Herrenschmidt