BMC/Intel-BMC/linux.git/drivers/fsi, branch dev-4.18

drivers/fsi: Add On-Chip Controller (OCC) driver

2018-08-27T23:49:29+00:00

The OCC is a device embedded on a POWER processor that collects and aggregates sensor data from the processor and system. The OCC can provide the raw sensor data as well as perform thermal and power management on the system. This driver provides an atomic communications channel between a service processor (e.g. a BMC) and the OCC. The driver is dependent on the FSI SBEFIFO driver to get hardware access through the SBE to the OCC SRAM. Commands are issued to the SBE to send or fetch data to the SRAM. This version of the driver uses the new fsi-core controlled chardev allocator and use a real cdev instead of a miscdev. OpenBMC-Staging-Count: 4 Signed-off-by: Edward A. James Signed-off-by: Andrew Jeffery Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Joel Stanley

fsi: sbefifo: Bump max command length

2018-08-27T22:17:32+00:00

Otherwise cronus putmem fails istep and BML fails to upload skiboot To do that, we still use our one-page command buffer for small commands for speed, and for anything bigger, with a limit of 1MB plus a page, we vmalloc a temporary buffer. The limit was chosen because Cronus will break up any data transfer into 1M chunks (the extra page is for the command header). Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Andrew Jeffery (cherry picked from commit 15e2a7218c2788d79c5633336d17cb9428c221e7) Signed-off-by: Joel Stanley

fsi: scom: Fix NULL dereference

2018-08-27T22:17:32+00:00

The chardev conversion forgot to copy the fsi_dev, silly mistake, compounded by a testing mistake on my side, this specific driver wasn't being tested properly. Fixes: d8f4587655f9 "fsi: scom: Convert to use the new chardev" Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit aa1221b2584f06066d1e6b22ef7950fb12d94864) Signed-off-by: Joel Stanley

fsi: Prevent multiple concurrent rescans

2018-08-27T22:17:32+00:00

The bus scanning process isn't terribly good at parallel attempts at rescanning the same bus. Let's have a per-master mutex protecting the scanning process. Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit 9840fcd8cc43bfba486a53b4461044f1a1189cdc) Signed-off-by: Joel Stanley

fsi: Add cfam char devices

2018-08-27T22:17:32+00:00

This aims to deprecate the "raw" sysfs file used for directly accessing the CFAM and instead use a char device like the other sub drivers. Since it reworks the slave creation code and adds a cfam device type, we also use the opportunity to convert the attributes to attribute groups and add a couple more. Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit d1dcd678257603e71cf3f3d84c70e2b6f0f14bb8) Signed-off-by: Joel Stanley

fsi: scom: Convert to use the new chardev

2018-08-27T22:17:32+00:00

This converts FSI scom to use the new fsi-core controlled chardev allocator and use a real cdev instead of a miscdev. Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit d8f4587655f9682127351a9dc3fca61e70744294) Signed-off-by: Joel Stanley

fsi: sbefifo: Convert to use the new chardev

2018-08-27T22:17:32+00:00

This converts FSI sbefifo to use the new fsi-core controlled chardev allocator and use a real cdev instead of a miscdev. One side effect is to fix the object lifetime by removing the use of devm_kzalloc() for something that contains kobjects, and using proper reference counting. Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit 8b052dd64f998c7c8e0a0fd1d9feabc0e9bcfe42) Signed-off-by: Joel Stanley

fsi: Add new central chardev support

2018-08-27T22:17:32+00:00

The various FSI devices (sbefifo, occ, scom, more to come) currently use misc devices. This is problematic as the minor device space for misc is limited and there can be a lot of them. Also it limits our ability to move them to a dedicated /dev/fsi directory or to be smart about device naming and numbering. It also means we have IDAs on every single of these drivers This creates a common fsi "device_type" for the optional /dev/fsi grouping and a dev_t allocator for all FSI devices. "Legacy" devices get to use a backward compatible numbering scheme (as long as chip id <16 and there's only one copy of a given unit type per chip). A single major number and a single IDA are shared for all FSI devices. This doesn't convert the FSI device drivers to use the new scheme yet, they will be converted individually. Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit 0ab5fe5374743d5a279b1ff6297ef2c54d06cd5f) Signed-off-by: Joel Stanley

fsi: master-ast-cf: Rename dump_trace() to avoid name collision

2018-08-27T22:17:32+00:00

s390 defines a global dump_trace() symbol. Rename ours to dump_ucode_trace() to avoid a collision in build tests. Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit 537052df223408b25bdd77dbb9bf40080f514d3c) Signed-off-by: Joel Stanley

fsi: master-ast-cf: Fix memory leak

2018-08-27T22:17:32+00:00

In case memory resources for *fw* were allocated, release them before return. Addresses-Coverity-ID: 1472044 ("Resource leak") Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Benjamin Herrenschmidt (cherry picked from commit 502defbb476bca222ddb5a78f2cc19c12c4e42f3) Signed-off-by: Joel Stanley