BMC/Intel-BMC/linux.git/crypto/sm3_generic.c, branch dev-4.19Intel OpenBMC Linux kernel source tree (mirror)https://git.radix-linux.su/BMC/Intel-BMC/linux.git/atom?h=dev-4.192019-01-22T20:40:31+00:00crypto: sm3 - fix undefined shift by >= width of value2019-01-22T20:40:31+00:00Eric Biggersebiggers@google.com2019-01-09T06:12:41+00:00urn:sha1:68afc7c36461a5989b91ca88f82bbcd90dece24d
commit d45a90cb5d061fa7d411b974b950fe0b8bc5f265 upstream.
sm3_compress() calls rol32() with shift >= 32, which causes undefined
behavior. This is easily detected by enabling CONFIG_UBSAN.
Explicitly AND with 31 to make the behavior well defined.
Fixes: 4f0fc1600edb ("crypto: sm3 - add OSCCA SM3 secure hash")
Cc: <stable@vger.kernel.org> # v4.15+
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto: shash - remove useless setting of type flags2018-07-08T16:30:24+00:00Eric Biggersebiggers@google.com2018-06-30T22:16:11+00:00urn:sha1:e50944e219f908968a6e01fbd0e8811a33bd5f04
Many shash algorithms set .cra_flags = CRYPTO_ALG_TYPE_SHASH. But this
is redundant with the C structure type ('struct shash_alg'), and
crypto_register_shash() already sets the type flag automatically,
clearing any type flag that was already there. Apparently the useless
assignment has just been copy+pasted around.
So, remove the useless assignment from all the shash algorithms.
This patch shouldn't change any actual behavior.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sm3 - add OSCCA SM3 secure hash2017-09-22T09:43:07+00:00Gilad Ben-Yossefgilad@benyossef.com2017-08-21T10:51:28+00:00urn:sha1:4f0fc1600edbdb3612b931aa5076ca984f7ee8fe
Add OSCCA SM3 secure hash (OSCCA GM/T 0004-2012 SM3)
generic hash transformation.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>