BMC/Intel-BMC/linux.git/block/partitions/core.c, branch dev-5.7Intel OpenBMC Linux kernel source tree (mirror)https://git.radix-linux.su/BMC/Intel-BMC/linux.git/atom?h=dev-5.72020-04-30T16:25:43+00:00block: remove the bd_openers checks in blk_drop_partitions2020-04-30T16:25:43+00:00Christoph Hellwighch@lst.de2020-04-28T08:52:03+00:00urn:sha1:10c70d95c0f2f9a6f52d0e33243d2877370cef51
When replacing the bd_super check with a bd_openers I followed a logical
conclusion, which turns out to be utterly wrong. When a block device has
bd_super sets it has a mount file system on it (although not every
mounted file system sets bd_super), but that also implies it doesn't even
have partitions to start with.
So instead of trying to come up with a logical check for all openers,
just remove the check entirely.
Fixes: d3ef5536274f ("block: fix busy device checking in blk_drop_partitions")
Fixes: cb6b771b05c3 ("block: fix busy device checking in blk_drop_partitions again")
Reported-by: Michal Koutný <mkoutny@suse.com>
Reported-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block: fix busy device checking in blk_drop_partitions again2020-04-10T14:34:11+00:00Christoph Hellwighch@lst.de2020-04-10T12:31:47+00:00urn:sha1:cb6b771b05c3026a85ed4817c1b87c5e6f41d136
The previous fix had an off by one in the bd_openers checking, counting
the callers blkdev_get.
Fixes: d3ef5536274f ("block: fix busy device checking in blk_drop_partitions")
Reported-by: Qian Cai <cai@lca.pw>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Qian Cai <cai@lca.pw>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block: fix busy device checking in blk_drop_partitions2020-04-07T20:42:59+00:00Christoph Hellwighch@lst.de2020-04-04T06:51:20+00:00urn:sha1:d3ef5536274faf89e626276b833be122a16bdb81
bd_super is only set by get_tree_bdev and mount_bdev, and thus not by
other openers like btrfs or the XFS realtime and log devices, as well as
block devices directly opened from user space. Check bd_openers
instead.
Fixes: 77032ca66f86 ("Return EBUSY from BLKRRPART for mounted whole-dev fs")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block: move block layer internals out of include/linux/genhd.h2020-03-25T15:50:08+00:00Christoph Hellwighch@lst.de2020-03-25T15:48:41+00:00urn:sha1:581e26004a09c50e5017caadc850ea17e374a5ee
None of this needs to be exposed to drivers.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block: merge partition-generic.c and check.c2020-03-24T13:57:08+00:00Christoph Hellwighch@lst.de2020-03-24T07:25:30+00:00urn:sha1:387048bf67eeff8bdf7c2a41b03b48230a88b3d3
Merge block/partition-generic.c and block/partitions/check.c into
a single block/partitions/core.c as the content is closely related
and both files are tiny.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>