BMC/Intel-BMC/linux.git/arch/blackfin/include/asm/uaccess.h, branch dev

blackfin: macro whitespace fixes

2015-01-13T13:23:47+00:00

While working on arch/blackfin/include/asm/uaccess.h, I noticed that some macros within this header are made harder to read because they violate a coding style rule: space is missing after comma. Fix it up. Signed-off-by: Michael S. Tsirkin

blackfin: fix put_user sparse errors

2015-01-13T13:23:32+00:00

virtio wants to write bitwise types to userspace using put_user. At the moment this triggers sparse errors, since the value is passed through an integer. For example: __le32 __user *p; __le32 x; put_user(x, p); is safe, but currently triggers a sparse warning. Fix that up using __force. Note: this does not suppress any useful sparse checks since caller assigns x to typeof(*p), which in turn forces all the necessary type checks. Signed-off-by: Michael S. Tsirkin

blackfin/uaccess: fix sparse errors

2015-01-13T13:23:07+00:00

virtio wants to read bitwise types from userspace using get_user. At the moment this triggers sparse errors, since the value is passed through an integer. Fix that up using __force. Signed-off-by: Michael S. Tsirkin Acked-by: Steven Miao

blackfin: sync data in blackfin write buffer

2013-02-20T07:21:23+00:00

Sync data in blackfin write buffer to DRAM before return from copy_to_user. Otherwise, application may read wrong data from stat syscall occasionally. Signed-off-by: Sonic Zhang Signed-off-by: Bob Liu

Blackfin: remove unused is_in_rom()

2012-12-13T05:50:57+00:00

The function is not used anywhere in the whole tree (anymore), so remove it. Signed-off-by: Tobias Klauser Signed-off-by: Mike Frysinger Signed-off-by: Bob Liu

Blackfin: Annotate strnlen_user and strlen_user 'src' parameter with __user

2012-12-13T05:50:57+00:00

The 'src' parameter of strnlen_user and strlen_user is supposed to take a userspace pointer, so annotate it with __user. This fixes the following and similar sparse warnings: fs/binfmt_elf_fdpic.c:671:36: warning: incorrect type in argument 1 (different address spaces) fs/binfmt_elf_fdpic.c:671:36: expected char const *src fs/binfmt_elf_fdpic.c:671:36: got char [noderef] *[assigned] p fs/binfmt_elf_fdpic.c:683:36: warning: incorrect type in argument 1 (different address spaces) fs/binfmt_elf_fdpic.c:683:36: expected char const *src fs/binfmt_elf_fdpic.c:683:36: got char [noderef] *[assigned] p Signed-off-by: Lars-Peter Clausen Signed-off-by: Bob Liu

Blackfin: Annotate clear_user 'to' parameter with __user

2012-12-13T05:50:57+00:00

The 'to' parameter of clear_user is supposed to take a userspace pointer, so annotate it with __user. This fixes the following and similar sparse warnings: fs/binfmt_elf_fdpic.c:714:35: warning: incorrect type in argument 1 (different address spaces) fs/binfmt_elf_fdpic.c:714:35: expected void [noderef] *to fs/binfmt_elf_fdpic.c:714:35: got void * fs/binfmt_elf_fdpic.c:1119:29: warning: incorrect type in argument 1 (different address spaces) fs/binfmt_elf_fdpic.c:1119:29: expected void *to fs/binfmt_elf_fdpic.c:1119:29: got void [noderef] * Signed-off-by: Lars-Peter Clausen Signed-off-by: Bob Liu

Blackfin: Add missing __user annotations to put_user

2012-12-13T05:50:56+00:00

typeof() will not inherit the __user annotation so we have to explicitly specify this for '_p'. This fixes the following and quite a few similar warnings from spatch: kernel/sys.c:884:26: warning: incorrect type in initializer (different address spaces) kernel/sys.c:884:26: expected unsigned int *_p kernel/sys.c:884:26: got unsigned int [noderef] [usertype] *ruidp kernel/sys.c:885:26: warning: incorrect type in initializer (different address spaces) kernel/sys.c:885:26: expected unsigned int *_p kernel/sys.c:885:26: got unsigned int [noderef] [usertype] *euidp kernel/sys.c:886:26: warning: incorrect type in initializer (different address spaces) kernel/sys.c:886:26: expected unsigned int *_p kernel/sys.c:886:26: got unsigned int [noderef] [usertype] *suidp Signed-off-by: Lars-Peter Clausen Signed-off-by: Bob Liu

Blackfin: Annotate strncpy_from_user src parameter with __user

2012-12-13T05:50:56+00:00

The src parameter of strncpy_from_user is supposed to take a string from userspace, so it should be annotated with __user. Doing so fixes the following and similar warnings from sparse: kernel/sys.c:491:51: warning: incorrect type in argument 2 (different address spaces) kernel/sys.c:491:51: expected char const *src kernel/sys.c:491:51: got void [noderef] *arg kernel/sys.c:2061:54: warning: incorrect type in argument 2 (different address spaces) kernel/sys.c:2061:54: expected char const *src kernel/sys.c:2061:54: got char [noderef] * Signed-off-by: Lars-Peter Clausen Signed-off-by: Bob Liu

Blackfin: fix sparse warnings in copy_to/from_user

2011-10-25T23:51:35+00:00

Fix argument types for copy_to_user. Fix following sparse warnings: arch/blackfin/include/asm/uaccess.h:198:14: warning: incorrect type in argument 2 (different address spaces) arch/blackfin/include/asm/uaccess.h:198:14: expected void const *s arch/blackfin/include/asm/uaccess.h:198:14: got void const [noderef] *from arch/blackfin/include/asm/uaccess.h:208:14: warning: incorrect type in argument 2 (different address spaces) arch/blackfin/include/asm/uaccess.h:208:14: expected void const *s arch/blackfin/include/asm/uaccess.h:208:14: got void const [noderef] *from Signed-off-by: Mikhail Gruzdev Signed-off-by: Mike Frysinger